From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boXEg-00035d-BT for qemu-devel@nongnu.org; Mon, 26 Sep 2016 10:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boXEa-0007RH-Jb for qemu-devel@nongnu.org; Mon, 26 Sep 2016 10:50:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boXEa-0007RA-DJ for qemu-devel@nongnu.org; Mon, 26 Sep 2016 10:50:20 -0400 References: <1474899464-14849-1-git-send-email-felipe@nutanix.com> From: Laurent Vivier Message-ID: <03f73e32-0c68-7bf5-f73e-73a2a90e5a01@redhat.com> Date: Mon, 26 Sep 2016 16:50:16 +0200 MIME-Version: 1.0 In-Reply-To: <1474899464-14849-1-git-send-email-felipe@nutanix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felipe Franciosi , Eric Blake , David Gibson Cc: "qemu-devel@nongnu.org" On 26/09/2016 16:17, Felipe Franciosi wrote: > A typo introduced in f19661c8 prevents qemu from building when configured > with --enable-trace-backend=dtrace. > > Signed-off-by: Felipe Franciosi Reviewed-by: Laurent Vivier > --- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index d8a2296..6090a20 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -658,7 +658,7 @@ static void vscsi_process_login(VSCSIState *s, vscsi_req *req) > struct srp_login_rsp *rsp = &iu->srp.login_rsp; > uint64_t tag = iu->srp.rsp.tag; > > - trace_spapr_vscsi__process_login(); > + trace_spapr_vscsi_process_login(); > > /* TODO handle case that requested size is wrong and > * buffer format is wrong > diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events > index d1995b8..4a2e5d6 100644 > --- a/hw/scsi/trace-events > +++ b/hw/scsi/trace-events > @@ -225,7 +225,7 @@ spapr_vscsi_command_complete_sense_data2(unsigned s8, unsigned s9, unsigned s10, > spapr_vscsi_command_complete_status(uint32_t status) "Command complete err=%"PRIu32 > spapr_vscsi_save_request(uint32_t qtag, unsigned desc, unsigned offset) "saving tag=%"PRIu32", current desc#%u, offset=0x%x" > spapr_vscsi_load_request(uint32_t qtag, unsigned desc, unsigned offset) "restoring tag=%"PRIu32", current desc#%u, offset=0x%x" > -spapr_vscsi__process_login(void) "Got login, sending response !" > +spapr_vscsi_process_login(void) "Got login, sending response !" > spapr_vscsi_queue_cmd_no_drive(uint64_t lun) "Command for lun %08" PRIx64 " with no drive" > spapr_vscsi_queue_cmd(uint32_t qtag, unsigned cdb, const char *cmd, int lun, int ret) "Queued command tag 0x%"PRIx32" CMD 0x%x=%s LUN %d ret: %d" > spapr_vscsi_do_crq(unsigned c0, unsigned c1) "crq: %02x %02x ..." >