Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 18/1/23 22:28, Fabiano Rosas wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> Hi Fabiano,
>>
>> On 18/1/23 20:34, Fabiano Rosas wrote:
>>> These are the already reviewed patches from the first half of my
>>> previous series:
>>> https://lore.kernel.org/r/20230113140419.4013-1-farosas@suse.de
>>>
>>> This unbreaks the --disable-tcg build, but there are issues in runtime
>>> that are still being hashed out in the other series.
>>>
>>> For the build _with_ TCG, this should behave the same as master.
>>>
>>> Based on Richard's "target/arm: Introduce aarch64_set_svcr":
>>> https://lore.kernel.org/r/20230112004322.161330-1-richard.henderson@linaro.org
>>
>> $ git am
>> 20230111_richard_henderson_target_arm_introduce_aarch64_set_svcr.mbx
>> Applying: target/arm: Introduce aarch64_set_svcr
>> $ git am ./20230118_farosas_target_arm_config_tcg_n_part_1.mbx
>> Applying: target/arm: rename handle_semihosting to tcg_handle_semihosting
>> Applying: target/arm: wrap psci call with tcg_enabled
>> Applying: target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()
>> Applying: target/arm: Move PC alignment check
>> Applying: target/arm: Move cpregs code out of cpu.h
>> Applying: target/arm: Move define_debug_regs() to cpregs.c
>> error: target/arm/cpregs.c: does not exist in index
>> Patch failed at 0006 target/arm: Move define_debug_regs() to cpregs.c
>>
>> I am based on commit 7ec8aeb604 ("Merge tag 'pull-tpm-2023-01-17-1' of
>> https://github.com/stefanberger/qemu-tpm into staging"), what am I missing?
> 
> How did you fetch the series? You are missing patch 06. Maybe it is too
> big for the method you used?

Actually the tool warned about patch 6 missing, but I didn't notice:

$ b4 am 20230118193518.26433-1-farosas@suse.de
Grabbing thread from 
lore.kernel.org/all/20230118193518.26433-1-farosas%40suse.de/t.mbox.gz
Analyzing 20 messages in the thread
Checking attestation on all messages, may take a moment...
---
   ✓ [PATCH 1/20] target/arm: rename handle_semihosting to 
tcg_handle_semihosting
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 2/20] target/arm: wrap psci call with tcg_enabled
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 3/20] target/arm: wrap call to aarch64_sve_change_el in 
tcg_enabled()
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 4/20] target/arm: Move PC alignment check
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 5/20] target/arm: Move cpregs code out of cpu.h
     ✓ Signed: DKIM/suse.de
   ERROR: missing [6/20]!
   ✓ [PATCH 7/20] target/arm: Move define_debug_regs() to cpregs.c
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 8/20] target/arm: Wrap breakpoint/watchpoint updates with 
tcg_enabled
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 9/20] target/arm: move translate modules to tcg/
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 10/20] target/arm: move helpers to tcg/
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 11/20] target/arm: Move psci.c into the tcg directory
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 12/20] target/arm: Wrap arm_rebuild_hflags calls with 
tcg_enabled
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 13/20] target/arm: Move hflags code into the tcg directory
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 14/20] target/arm: Move regime_using_lpae_format into internal.h
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 15/20] target/arm: Don't access TCG code when debugging with KVM
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 16/20] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 17/20] target/arm: Move cortex sysregs into cpregs.c
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 18/20] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 19/20] tests/avocado: Skip tests that require a missing 
accelerator
     ✓ Signed: DKIM/suse.de
   ✓ [PATCH 20/20] tests/avocado: Tag TCG tests with accel:tcg
     ✓ Signed: DKIM/suse.de
---
Total patches: 19
---
WARNING: Thread incomplete!

Indeed patch 6 is missing:
https://lore.kernel.org/qemu-devel/20230118193518.26433-1-farosas@suse.de/