From: Jason Wang <jasowang@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions
Date: Fri, 22 Dec 2017 10:07:40 +0800 [thread overview]
Message-ID: <040fe249-f3d6-05b5-b7d4-01d757f47e2e@redhat.com> (raw)
In-Reply-To: <19ebcc01-3299-2ec9-7089-cba5abde400f@ilande.co.uk>
On 2017年12月20日 16:58, Mark Cave-Ayland wrote:
>> Series looks good to me.
>>
>> A small question is that, is this better to keep compute_mcast_idx()?
>>
>> Thanks
>
> Hi Jason,
>
> I did think about this, however at the very minimum you'd need
> big-endian and little-endian variants of compute_mcast_idx(), and then
> you see that eepro100 applies a different bitmask/shift which is yet
> another variant...
>
> For this reason I moved them all inline to the QEMU driver and that
> made it possible to compare the hash calculation directly with the
> corresponding Linux driver which found the 3 potential bugs above. So
> I think this is a net win (pardon the pun) on all sides :)
>
>
> ATB,
Ok, applied.
Thanks
prev parent reply other threads:[~2017-12-22 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 18:41 [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 01/13] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 02/13] net: introduce net_crc32_le() function Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 03/13] pcnet: switch pcnet over to use net_crc32_le() Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 04/13] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32() Mark Cave-Ayland
2017-12-15 19:45 ` Philippe Mathieu-Daudé
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 05/13] sunhme: switch sunhme over to use net_crc32_le() Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 06/13] sungem: fix multicast filter CRC calculation Mark Cave-Ayland
2017-12-15 19:46 ` Philippe Mathieu-Daudé
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 07/13] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx() Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 08/13] opencores_eth: " Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 09/13] lan9118: " Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 10/13] ftgmac100: " Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 11/13] ne2000: " Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 12/13] rtl8139: " Mark Cave-Ayland
2017-12-15 18:41 ` [Qemu-devel] [PATCHv3 13/13] net: remove unused compute_mcast_idx() function Mark Cave-Ayland
2017-12-20 8:35 ` [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions Jason Wang
2017-12-20 8:58 ` Mark Cave-Ayland
2017-12-22 2:07 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040fe249-f3d6-05b5-b7d4-01d757f47e2e@redhat.com \
--to=jasowang@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).