Re: [PATCH 05/10] accel/tcg: Hoist cpu_get_tb_cpu_state decl to accl/tcg/cpu-ops.h

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 4/28/25 1:10 PM, Richard Henderson wrote:
> For some targets, simply remove the local definition.
> For other targets, move the inline definition out of line.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/accel/tcg/cpu-ops.h |  3 ++
>   target/alpha/cpu.h          | 11 ------
>   target/arm/cpu.h            |  3 --
>   target/avr/cpu.h            | 18 ----------
>   target/hexagon/cpu.h        | 15 --------
>   target/hppa/cpu.h           |  3 --
>   target/i386/cpu.h           | 14 --------
>   target/loongarch/cpu.h      | 12 -------
>   target/m68k/cpu.h           | 16 ---------
>   target/microblaze/cpu.h     |  8 -----
>   target/mips/cpu.h           |  9 -----
>   target/openrisc/cpu.h       | 10 ------
>   target/ppc/cpu.h            | 13 -------
>   target/riscv/cpu.h          |  3 --
>   target/rx/cpu.h             |  9 -----
>   target/s390x/cpu.h          |  9 -----
>   target/sh4/cpu.h            | 15 --------
>   target/sparc/cpu.h          |  3 --
>   target/tricore/cpu.h        | 12 -------
>   target/xtensa/cpu.h         | 68 -----------------------------------
>   target/alpha/cpu.c          | 14 ++++++--
>   target/arm/helper.c         |  1 +
>   target/avr/cpu.c            | 21 +++++++++--
>   target/hexagon/cpu.c        | 18 ++++++++--
>   target/hppa/cpu.c           |  3 +-
>   target/i386/tcg/tcg-cpu.c   | 17 +++++++--
>   target/loongarch/cpu.c      | 15 ++++++--
>   target/m68k/cpu.c           | 19 ++++++++--
>   target/microblaze/cpu.c     | 11 ++++--
>   target/mips/cpu.c           |  9 +++++
>   target/openrisc/cpu.c       | 13 +++++--
>   target/ppc/helper_regs.c    | 16 ++++-----
>   target/rx/cpu.c             | 12 +++++--
>   target/s390x/cpu.c          |  1 +
>   target/sh4/cpu.c            | 18 ++++++++--
>   target/tricore/cpu.c        | 15 ++++++--
>   target/xtensa/cpu.c         | 71 +++++++++++++++++++++++++++++++++++--
>   37 files changed, 243 insertions(+), 285 deletions(-)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>