* [Qemu-devel] [PATCH resend] hbitmap: fix missing restore count when finish deserialization
@ 2018-01-18 13:13 Liang Li
2018-01-18 18:47 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Liang Li @ 2018-01-18 13:13 UTC (permalink / raw)
To: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy
Cc: Fam Zheng, Max Reitz, John Snow, Weiping Zhang
The .count of HBitmap is forgot to set in function
hbitmap_deserialize_finish, let's set it to the right value.
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Fam Zheng <famz@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Weiping Zhang <zhangweiping@didichuxing.com>
Signed-off-by: Liang Li <liliangleo@didichuxing.com>
---
util/hbitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/hbitmap.c b/util/hbitmap.c
index 289778a..58a2c93 100644
--- a/util/hbitmap.c
+++ b/util/hbitmap.c
@@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
}
bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
+ bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
}
void hbitmap_free(HBitmap *hb)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH resend] hbitmap: fix missing restore count when finish deserialization
2018-01-18 13:13 [Qemu-devel] [PATCH resend] hbitmap: fix missing restore count when finish deserialization Liang Li
@ 2018-01-18 18:47 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2018-01-18 18:47 UTC (permalink / raw)
To: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy, Fam Zheng,
Max Reitz, Weiping Zhang
On 01/18/2018 08:13 AM, Liang Li wrote:
> The .count of HBitmap is forgot to set in function
> hbitmap_deserialize_finish, let's set it to the right value.
>
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: John Snow <jsnow@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Signed-off-by: Weiping Zhang <zhangweiping@didichuxing.com>
> Signed-off-by: Liang Li <liliangleo@didichuxing.com>
>
> ---
> util/hbitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/hbitmap.c b/util/hbitmap.c
> index 289778a..58a2c93 100644
> --- a/util/hbitmap.c
> +++ b/util/hbitmap.c
> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
> }
>
> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
> }
>
> void hbitmap_free(HBitmap *hb)
>
Reviewed-by: John Snow <jsnow@redhat.com>
and
Thanks, applied to my bitmaps tree:
https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-18 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18 13:13 [Qemu-devel] [PATCH resend] hbitmap: fix missing restore count when finish deserialization Liang Li
2018-01-18 18:47 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).