From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B02C433E2 for ; Thu, 28 May 2020 21:54:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FE50206F1 for ; Thu, 28 May 2020 21:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tb+bfidc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FE50206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeQTn-0002gA-8N for qemu-devel@archiver.kernel.org; Thu, 28 May 2020 17:54:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeQSw-0001ot-AH for qemu-devel@nongnu.org; Thu, 28 May 2020 17:53:30 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43288 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeQSu-0002LR-Lz for qemu-devel@nongnu.org; Thu, 28 May 2020 17:53:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590702807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GiVumsXOj6XnWRoyp7j8nZNDqWEQBH1FAMwCBk4UFKE=; b=Tb+bfidc61rVN2OJQ3yBy33tNwJHTBcWWAB9uovxb5X4xmOU4E8Shj4XTCnotUTUQzPfey qB9gWlcIS6QttHpr+svbQmw2Le9TPhFjLglSOpjD/nisq46CJ0tfGNeid7ff+vIOUHjQyS p6gvWSvSFhWp8LI7GPSKRSuKhpgAoy4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-e215EmtEMfO9UYzBHDxWlg-1; Thu, 28 May 2020 17:53:25 -0400 X-MC-Unique: e215EmtEMfO9UYzBHDxWlg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9E8518FF661; Thu, 28 May 2020 21:53:23 +0000 (UTC) Received: from [10.3.112.88] (ovpn-112-88.phx2.redhat.com [10.3.112.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C1ED5D9CD; Thu, 28 May 2020 21:53:14 +0000 (UTC) Subject: Re: [PATCH v7 6/8] block: make BlockConf size props 32bit and accept size suffixes To: Roman Kagan , qemu-devel@nongnu.org References: <20200528213946.1636444-1-rvkagan@yandex-team.ru> <20200528213946.1636444-7-rvkagan@yandex-team.ru> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <0439aa5e-413c-cf7e-83b7-1e942a882f5a@redhat.com> Date: Thu, 28 May 2020 16:53:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200528213946.1636444-7-rvkagan@yandex-team.ru> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 17:53:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Stefano Stabellini , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , qemu-block@nongnu.org, Paul Durrant , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" , Laurent Vivier , Max Reitz , Anthony Perard , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , Keith Busch , xen-devel@lists.xenproject.org, John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/28/20 4:39 PM, Roman Kagan wrote: > Convert all size-related properties in BlockConf to 32bit. This will > allow to accomodate bigger block sizes (in a followup patch). s/allow to accomodate/accommodate/ > This also allows to make them all accept size suffixes, either via > DEFINE_PROP_BLOCKSIZE or via DEFINE_PROP_SIZE32. > > Also, since min_io_size is exposed to the guest by scsi and virtio-blk > devices as an uint16_t in units of logical blocks, introduce an > additional check in blkconf_blocksizes to prevent its silent truncation. > > Signed-off-by: Roman Kagan > --- > + if (conf->min_io_size / conf->logical_block_size > UINT16_MAX) { > + error_setg(errp, > + "min_io_size must not exceed " stringify(UINT16_MAX) > + " logical blocks"); On my libc, this results in "must not exceed (65535) logical blocks". Worse, I could envision a platform where it prints something funky like: "exceed (2 * (32768) + 1) logical", based on however complex the definition of UINT16_MAX is. You're better off printing this one with %d than with stringify(). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org