From: Eric Blake <eblake@redhat.com>
To: Yuval Shaia <yuval.shaia@oracle.com>,
marcel.apfelbaum@gmail.com, dmitry.fleytman@gmail.com,
jasowang@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, shamir.rabinovitch@oracle.com,
cohuck@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 11/23] hw/pvrdma: Add support to allow guest to configure GID table
Date: Mon, 17 Dec 2018 10:02:19 -0600 [thread overview]
Message-ID: <0443a8ef-f94a-0d1c-56ff-9c134ba6d7ff@redhat.com> (raw)
In-Reply-To: <20181217081047.2039-12-yuval.shaia@oracle.com>
On 12/17/18 2:10 AM, Yuval Shaia wrote:
> The control over the RDMA device's GID table is done by updating the
> device's Ethernet function addresses.
> Usually the first GID entry is determined by the MAC address, the second
> by the first IPv6 address and the third by the IPv4 address. Other
> entries can be added by adding more IP addresses. The opposite is the
> same, i.e. whenever an address is removed, the corresponding GID entry
> is removed.
>
> The process is done by the network and RDMA stacks. Whenever an address
> is added the ib_core driver is notified and calls the device driver
> add_gid function which in turn update the device.
>
> To support this in pvrdma device we need to hook into the create_bind
> and destroy_bind HW commands triggered by pvrdma driver in guest.
> Whenever changed is made to the pvrdma port's GID table a special QMP
s/changed/a change/
> messages is sent to be processed by libvirt to update the address of the
s/messages/message/
> backend Ethernet device.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-17 16:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 8:10 [Qemu-devel] [PATCH v7 00/23] Add support for RDMA MAD Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 01/23] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 02/23] hw/rdma: Add ability to force notification without re-arm Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 03/23] hw/rdma: Return qpn 1 if ibqp is NULL Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 04/23] hw/rdma: Abort send-op if fail to create addr handler Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 05/23] hw/rdma: Add support for MAD packets Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 06/23] hw/pvrdma: Make function reset_device return void Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 07/23] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 08/23] hw/pvrdma: Set the correct opcode for recv completion Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 09/23] hw/pvrdma: Set the correct opcode for send completion Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 10/23] qapi: Define new QMP message for pvrdma Yuval Shaia
2018-12-17 16:00 ` Eric Blake
2018-12-17 18:33 ` Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 11/23] hw/pvrdma: Add support to allow guest to configure GID table Yuval Shaia
2018-12-17 16:02 ` Eric Blake [this message]
2018-12-17 18:31 ` Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 12/23] vmxnet3: Move some definitions to header file Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 13/23] hw/pvrdma: Make sure PCI function 0 is vmxnet3 Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 14/23] hw/rdma: Initialize node_guid from vmxnet3 mac address Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 15/23] hw/pvrdma: Make device state depend on Ethernet function state Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 16/23] hw/pvrdma: Fill all CQE fields Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 17/23] hw/pvrdma: Fill error code in command's response Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 18/23] hw/rdma: Remove unneeded code that handles more that one port Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 19/23] vl: Introduce shutdown_notifiers Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 20/23] hw/pvrdma: Clean device's resource when system is shutdown Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 21/23] hw/rdma: Do not use bitmap_zero_extend to free bitmap Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 22/23] hw/rdma: Do not call rdma_backend_del_gid on an empty gid Yuval Shaia
2018-12-17 8:10 ` [Qemu-devel] [PATCH v7 23/23] docs: Update pvrdma device documentation Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0443a8ef-f94a-0d1c-56ff-9c134ba6d7ff@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shamir.rabinovitch@oracle.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).