From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E19F9C36008 for ; Sat, 29 Mar 2025 09:31:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tySVv-0002RO-TO; Sat, 29 Mar 2025 05:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tySVj-0002Po-CL; Sat, 29 Mar 2025 05:29:52 -0400 Received: from out30-98.freemail.mail.aliyun.com ([115.124.30.98]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tySVd-0006kS-Km; Sat, 29 Mar 2025 05:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1743240577; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=61qpGYyF2d/tvy2q4U3tO32VaekDmkjJuxunVc4vdUU=; b=q5AW21K/NsUyiG5Ix/hKodh8D17vYLsj/OOFhn1Z13xjwjFKaVUm7kzfPQK8mxg9hCfE5Z3/vaqeTyl+ucz2yZyBZD4o+WpTBY6RiEvDkFnCe62Y1tAOmGjiBa3LNKO4Il+94M5AN8hE3sBHDvErdwIYb+n+hz6W3M4NIeD+7HQ= Received: from 30.166.64.61(mailfrom:zhiwei_liu@linux.alibaba.com fp:SMTPD_---0WTIf1qe_1743240574 cluster:ay36) by smtp.aliyun-inc.com; Sat, 29 Mar 2025 17:29:35 +0800 Message-ID: <044c4a98-db49-446c-a0dc-9b84cc59851d@linux.alibaba.com> Date: Sat, 29 Mar 2025 17:29:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] target/riscv: pmp: remove redundant check in pmp_is_locked To: =?UTF-8?Q?Lo=C3=AFc_Lefort?= , qemu-devel@nongnu.org Cc: Weiwei Li , qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Daniel Henrique Barboza References: <20250313193011.720075-1-loic@rivosinc.com> <20250313193011.720075-6-loic@rivosinc.com> Content-Language: en-US From: LIU Zhiwei In-Reply-To: <20250313193011.720075-6-loic@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.98; envelope-from=zhiwei_liu@linux.alibaba.com; helo=out30-98.freemail.mail.aliyun.com X-Spam_score_int: -174 X-Spam_score: -17.5 X-Spam_bar: ----------------- X-Spam_report: (-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2025/3/14 03:30, Loïc Lefort wrote: > Remove useless check in pmp_is_locked, the function will return 0 in either > case. > > Signed-off-by: Loïc Lefort > Reviewed-by: Daniel Henrique Barboza Reviewed-by: LIU Zhiwei Zhiwei > --- > target/riscv/pmp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c > index 845915e0c8..c685f7f2c5 100644 > --- a/target/riscv/pmp.c > +++ b/target/riscv/pmp.c > @@ -58,11 +58,6 @@ static inline int pmp_is_locked(CPURISCVState *env, uint32_t pmp_index) > return 1; > } > > - /* Top PMP has no 'next' to check */ > - if ((pmp_index + 1u) >= MAX_RISCV_PMPS) { > - return 0; > - } > - > return 0; > } >