From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMWc6-0001fZ-ER for qemu-devel@nongnu.org; Mon, 11 Jul 2016 04:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMWc2-0004FV-9u for qemu-devel@nongnu.org; Mon, 11 Jul 2016 04:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMWc2-0004FH-50 for qemu-devel@nongnu.org; Mon, 11 Jul 2016 04:30:46 -0400 References: <1467706769-12505-1-git-send-email-peterx@redhat.com> <1467706769-12505-5-git-send-email-peterx@redhat.com> <5780B278.7020001@web.de> <20160711053219.GB3204@pxdev.xzpeter.org> <20160711064904.GC3204@pxdev.xzpeter.org> <20160711074153.GD3204@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <044c6ef1-3c8b-0905-466f-bd45fc949a84@redhat.com> Date: Mon, 11 Jul 2016 10:30:38 +0200 MIME-Version: 1.0 In-Reply-To: <20160711074153.GD3204@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , David Kiarie Cc: Jan Kiszka , QEMU Developers , imammedo@redhat.com, rth@twiddle.net, Eduardo Habkost , jasowang@redhat.com, Marcel Apfelbaum , "Michael S. Tsirkin" , rkrcmar@redhat.com, Alex Williamson , wexu@redhat.com On 11/07/2016 09:41, Peter Xu wrote: > As mentioned in previous email, before Marcel's patches, > vtd_host_dma_iommu() was named q35_host_dma_iommu(). At that time, I > need "find_add_as" to let Q35 codes get rid of direct calls to VT-d > (so that pc_q35.c will not need to include "intel_iommu.h" any more, > instead, it should include "x86-iommu.h"). Also, that interface is > prepared for future AMD as well. However, now AMD (you patches) are > directly calling pci_setup_iommu(). I am not sure whether you were > using it from the beginning, but IIUC as long as you are using > pci_setup_iommu() interface, we should be able to avoid providing > find_add_as any more. So I think this patch is indeed okay to be > dropped... Please kindly correct me if I missed anything. :) > > The only reason that we keep this patch (as far as I can think of..) > is that mst has done some testing on v11 and I'm not sure whether we'd > better keep it untouched if we are going to merge it (fixing commit > message does not count, right?). But I'd say I'm not familiar with how > maintainers manage codes to be merged... Maybe different maintainers > have their own flavor on this matter? I don't know. Anyway, these are > only my wild guess. > > For the problem you have encountered with IOAPIC, do you think it's > related to this patch? Have you tried to add some logs in e.g. > ioapic_service() to see what's wrong in there? You can send v12. mst will choose whether to merge v11 or v12. Paolo