qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] block/vvfat: Fix crash when reporting error about too many files in directory
@ 2018-07-18 15:28 Thomas Huth
  2018-07-18 22:58 ` Philippe Mathieu-Daudé
  2018-07-23 14:33 ` Kevin Wolf
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Huth @ 2018-07-18 15:28 UTC (permalink / raw)
  To: Kevin Wolf, qemu-block; +Cc: Max Reitz, qemu-devel

When using the vvfat driver with a directory that contains too many files,
QEMU currently crashes. We are trying to print the wrong path variable here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 block/vvfat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index fc41841..6ae7458 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -975,8 +975,7 @@ static int init_directories(BDRVVVFATState* s,
         if (mapping->mode & MODE_DIRECTORY) {
             mapping->begin = cluster;
             if(read_directory(s, i)) {
-                error_setg(errp, "Could not read directory %s",
-                           mapping->path);
+                error_setg(errp, "Could not read directory \"%s\"", s->path);
                 return -1;
             }
             mapping = array_get(&(s->mapping), i);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-24 11:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 15:28 [Qemu-devel] [PATCH] block/vvfat: Fix crash when reporting error about too many files in directory Thomas Huth
2018-07-18 22:58 ` Philippe Mathieu-Daudé
2018-07-23 14:33 ` Kevin Wolf
2018-07-24  9:56   ` Thomas Huth
2018-07-24 10:49     ` Kevin Wolf
2018-07-24 11:38       ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).