From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: build broken with --enable-gcrypt
Date: Thu, 27 Aug 2020 14:18:46 -0700 [thread overview]
Message-ID: <046eb29c-9c68-1baf-846e-decd65f567e0@linaro.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
The meson conversion seems to have not been properly accomplished for the
gcrypt option: we fail to link against -lgcrypt.
I tried aping the nettle bits, like the following, but it has no effect. I
don't understand how the "nettle" token works, honestly, since it doesn't
appear to be used at all.
r~
[-- Attachment #2: z.txt --]
[-- Type: text/plain, Size: 1151 bytes --]
diff --git a/configure b/configure
index b1e11397a8..4fd50c0275 100755
--- a/configure
+++ b/configure
@@ -6972,6 +6972,8 @@ if test "$gcrypt" = "yes" ; then
if test "$gcrypt_hmac" = "yes" ; then
echo "CONFIG_GCRYPT_HMAC=y" >> $config_host_mak
fi
+ echo "GCRYPT_CFLAGS=$gcrypt_cflags" >> $config_host_mak
+ echo "GCRYPT_LIBS=$gcrypt_libs" >> $config_host_mak
fi
if test "$nettle" = "yes" ; then
echo "CONFIG_NETTLE=y" >> $config_host_mak
diff --git a/meson.build b/meson.build
index f0fe5f8799..d45c548191 100644
--- a/meson.build
+++ b/meson.build
@@ -108,6 +108,11 @@ if 'CONFIG_NETTLE' in config_host
nettle = declare_dependency(compile_args: config_host['NETTLE_CFLAGS'].split(),
link_args: config_host['NETTLE_LIBS'].split())
endif
+gcrypt = not_found
+if 'CONFIG_GCRYPT' in config_host
+ gcrypt = declare_dependency(compile_args: config_host['GCRYPT_CFLAGS'].split(),
+ link_args: config_host['GCRYPT_LIBS'].split())
+endif
gnutls = not_found
if 'CONFIG_GNUTLS' in config_host
gnutls = declare_dependency(compile_args: config_host['GNUTLS_CFLAGS'].split(),
next reply other threads:[~2020-08-27 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 21:18 Richard Henderson [this message]
2020-08-28 9:02 ` build broken with --enable-gcrypt Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=046eb29c-9c68-1baf-846e-decd65f567e0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).