From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Damien Hedde" <damien.hedde@greensocs.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PULL 6/6] hw/input/lasips2: QOM'ify the Lasi PS/2
Date: Mon, 1 Nov 2021 11:31:19 -0400 [thread overview]
Message-ID: <04704da8-24c5-25d6-85e1-6f9901f00b24@linaro.org> (raw)
In-Reply-To: <20211101082747.2524909-7-laurent@vivier.eu>
On 11/1/21 4:27 AM, Laurent Vivier wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
> Message-Id: <20210920064048.2729397-4-f4bug@amsat.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> hw/hppa/lasi.c | 10 +++++++++-
> hw/input/lasips2.c | 38 ++++++++++++++++++++++++++++----------
> include/hw/input/lasips2.h | 17 +++++++++++++----
> 3 files changed, 50 insertions(+), 15 deletions(-)
This has broken the qtest-hppa device-introspection test:
ERROR:../src/qom/object.c:2011:object_get_canonical_path_component: code should not be reached
Broken pipe
Aborted (core dumped)
Also, the previous patch 5 does not compile on its own:
In file included from ../src/hw/input/lasips2.c:28:0:
/home/richard.henderson/qemu/src/include/hw/input/lasips2.h:17:18: error: field ‘reg’ has
incomplete type
MemoryRegion reg;
^~~
ninja: build stopped: subcommand failed.
Reverting to patch 4 builds, and passes the introspection test.
r~
next prev parent reply other threads:[~2021-11-01 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 8:27 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
2021-11-01 8:27 ` [PULL 1/6] monitor: Trim some trailing space from human-readable output Laurent Vivier
2021-11-01 8:27 ` [PULL 2/6] hw/core/machine: Add the missing delimiter in cpu_slot_to_string() Laurent Vivier
2021-11-01 8:27 ` [PULL 3/6] MAINTAINERS: Split HPPA TCG vs HPPA machines/hardware Laurent Vivier
2021-11-01 8:27 ` [PULL 4/6] hw/input/lasips2: Fix typos in function names Laurent Vivier
2021-11-01 8:27 ` [PULL 5/6] hw/input/lasips2: Move LASIPS2State declaration to 'hw/input/lasips2.h' Laurent Vivier
2021-11-01 8:27 ` [PULL 6/6] hw/input/lasips2: QOM'ify the Lasi PS/2 Laurent Vivier
2021-11-01 15:31 ` Richard Henderson [this message]
2021-11-01 15:43 ` Philippe Mathieu-Daudé
2021-11-02 16:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04704da8-24c5-25d6-85e1-6f9901f00b24@linaro.org \
--to=richard.henderson@linaro.org \
--cc=damien.hedde@greensocs.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).