From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH for-7.0] tests/tcg: really fix path to target configuration
Date: Tue, 29 Mar 2022 12:48:35 +0200 [thread overview]
Message-ID: <04797f5e-8f76-9868-23ae-daafd14353dc@gmail.com> (raw)
In-Reply-To: <20220329104514.815448-1-pbonzini@redhat.com>
On 29/3/22 12:45, Paolo Bonzini wrote:
> This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific
> Makefile variables path for user-mode", 2022-01-12) but it also used the
> wrong path; default.mak is used for config/devices, not config/targets.
I remember having tested this, so maybe I had dirty default.mak
files there? Sigh. Anyway:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> While at it, explain what the inclusion is about.
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/tcg/Makefile.target | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
> index ae8004c76e..acda5bcec2 100644
> --- a/tests/tcg/Makefile.target
> +++ b/tests/tcg/Makefile.target
> @@ -32,8 +32,10 @@
> all:
> -include ../../../config-host.mak
> -include ../config-$(TARGET).mak
> +
> +# Get semihosting definitions for user-mode emulation
> ifeq ($(CONFIG_USER_ONLY),y)
> --include $(SRC_PATH)/configs/targets/$(TARGET)/default.mak
> +-include $(SRC_PATH)/configs/targets/$(TARGET).mak
> endif
>
> # for including , in command strings
prev parent reply other threads:[~2022-03-29 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 10:45 [PATCH for-7.0] tests/tcg: really fix path to target configuration Paolo Bonzini
2022-03-29 10:48 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04797f5e-8f76-9868-23ae-daafd14353dc@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).