* [PATCH for-7.0] tests/tcg: really fix path to target configuration
@ 2022-03-29 10:45 Paolo Bonzini
2022-03-29 10:48 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2022-03-29 10:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé
This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific
Makefile variables path for user-mode", 2022-01-12) but it also used the
wrong path; default.mak is used for config/devices, not config/targets.
While at it, explain what the inclusion is about.
Cc: Alex Bennée <alex.bennee@linaro.org>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/tcg/Makefile.target | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index ae8004c76e..acda5bcec2 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -32,8 +32,10 @@
all:
-include ../../../config-host.mak
-include ../config-$(TARGET).mak
+
+# Get semihosting definitions for user-mode emulation
ifeq ($(CONFIG_USER_ONLY),y)
--include $(SRC_PATH)/configs/targets/$(TARGET)/default.mak
+-include $(SRC_PATH)/configs/targets/$(TARGET).mak
endif
# for including , in command strings
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-7.0] tests/tcg: really fix path to target configuration
2022-03-29 10:45 [PATCH for-7.0] tests/tcg: really fix path to target configuration Paolo Bonzini
@ 2022-03-29 10:48 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-29 10:48 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé
On 29/3/22 12:45, Paolo Bonzini wrote:
> This was attempted in commit 533b0a1a41 ("tests/tcg: Fix target-specific
> Makefile variables path for user-mode", 2022-01-12) but it also used the
> wrong path; default.mak is used for config/devices, not config/targets.
I remember having tested this, so maybe I had dirty default.mak
files there? Sigh. Anyway:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> While at it, explain what the inclusion is about.
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/tcg/Makefile.target | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
> index ae8004c76e..acda5bcec2 100644
> --- a/tests/tcg/Makefile.target
> +++ b/tests/tcg/Makefile.target
> @@ -32,8 +32,10 @@
> all:
> -include ../../../config-host.mak
> -include ../config-$(TARGET).mak
> +
> +# Get semihosting definitions for user-mode emulation
> ifeq ($(CONFIG_USER_ONLY),y)
> --include $(SRC_PATH)/configs/targets/$(TARGET)/default.mak
> +-include $(SRC_PATH)/configs/targets/$(TARGET).mak
> endif
>
> # for including , in command strings
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-29 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-29 10:45 [PATCH for-7.0] tests/tcg: really fix path to target configuration Paolo Bonzini
2022-03-29 10:48 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).