From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Clément Chigot" <chigot@adacore.com>
Subject: Re: [PATCH] target/i386/tcg: fix POP to memory in long mode
Date: Wed, 10 Jul 2024 08:18:18 -0700 [thread overview]
Message-ID: <04827c78-1757-4a7c-b0b4-7eefb1958499@linaro.org> (raw)
In-Reply-To: <20240710141328.388955-1-pbonzini@redhat.com>
On 7/10/24 07:13, Paolo Bonzini wrote:
> In long mode, POP to memory will write a full 64-bit value. However,
> the call to gen_writeback() in gen_POP will use MO_32 because the
> decoding table is incorrect.
>
> The bug was latent until commit aea49fbb01a ("target/i386: use gen_writeback()
> within gen_POP()", 2024-06-08), and then became visible because gen_op_st_v
> now receives op->ot instead of the "ot" returned by gen_pop_T0.
>
> Analyzed-by: Clément Chigot<chigot@adacore.com>
> Fixes: 5e9e21bcc4d ("target/i386: move 60-BF opcodes to new decoder", 2024-05-07)
> Tested-by: Clément Chigot<chigot@adacore.com>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target/i386/tcg/decode-new.c.inc | 2 +-
> target/i386/tcg/emit.c.inc | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2024-07-10 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 14:13 [PATCH] target/i386/tcg: fix POP to memory in long mode Paolo Bonzini
2024-07-10 15:18 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04827c78-1757-4a7c-b0b4-7eefb1958499@linaro.org \
--to=richard.henderson@linaro.org \
--cc=chigot@adacore.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).