From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E41C433DB for ; Wed, 20 Jan 2021 23:17:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2F3D235F7 for ; Wed, 20 Jan 2021 23:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2F3D235F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Mim-00059X-UJ for qemu-devel@archiver.kernel.org; Wed, 20 Jan 2021 18:17:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2MhV-0004DT-Tp for qemu-devel@nongnu.org; Wed, 20 Jan 2021 18:15:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2MhU-00030i-F4 for qemu-devel@nongnu.org; Wed, 20 Jan 2021 18:15:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611184543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B7tOvdbr5ix+6euSE+EeWicE8Sox34df4l4xyhWcGrE=; b=Voo28ySaIsoOyF+xkMMnRe/Xyflc6JmbWo1uVRZ7++DKbSlyFEtAAfScov8vPWXW1yCIye OGIelN6aSOp1OLGJFFvPmCiQV7MnnkzipzVHOQfPSZxlLyq8vjZsk9V21BpHctrgc0hebE 9tQpD+GadsvGND2y1pE9Hl4x5kxWJRI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-d3Bzr4jsO-C9WVIkp5EPcw-1; Wed, 20 Jan 2021 18:15:39 -0500 X-MC-Unique: d3Bzr4jsO-C9WVIkp5EPcw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52EDB15722; Wed, 20 Jan 2021 23:15:38 +0000 (UTC) Received: from [10.3.113.116] (ovpn-113-116.phx2.redhat.com [10.3.113.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B8A41A3D8; Wed, 20 Jan 2021 23:15:34 +0000 (UTC) Subject: Re: [PATCH 03/11] block/raw-format: implement .bdrv_cancel_in_flight handler To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20201118180433.11931-1-vsementsov@virtuozzo.com> <20201118180433.11931-4-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <0484adfa-2822-dfd6-b311-e947892d7376@redhat.com> Date: Wed, 20 Jan 2021 17:15:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201118180433.11931-4-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/18/20 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: > We are going to cancel in-flight requests on mirror nbd target on job > cancel. Still nbd is often used not directly but as raw-format child. > So, add pass-through handler here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/raw-format.c | 6 ++++++ > 1 file changed, 6 insertions(+) Should all filters do this automatically (or rather, should the block layer do this automatically for all filters)? But I understand that it does NOT make sense for format drivers in general (cancelling a guest request may still require metadata updates), where raw-format is the exception, so doing it in raw-format instead of the block layer makes sense. > BlockDriver bdrv_raw = { > .format_name = "raw", > .instance_size = sizeof(BDRVRawState), > @@ -608,6 +613,7 @@ BlockDriver bdrv_raw = { > .bdrv_has_zero_init = &raw_has_zero_init, > .strong_runtime_opts = raw_strong_runtime_opts, > .mutable_opts = mutable_opts, > + .bdrv_cancel_in_flight = raw_cancel_in_flight, A demonstration of why I don't like aligning the =. But it's merely cosmetic, so doesn't affect: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org