From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLFD-0003SQ-IA for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:14:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLFA-0001YM-DA for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:14:43 -0500 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:46760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emLFA-0001YE-7u for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:14:40 -0500 Received: by mail-qk0-x243.google.com with SMTP id g129so16735787qkb.13 for ; Thu, 15 Feb 2018 07:14:40 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= References: <20180215042900.16078-1-f4bug@amsat.org> <20180215042900.16078-16-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <0498fd1e-c98c-f40e-bf8d-553bf3884b63@amsat.org> Date: Thu, 15 Feb 2018 12:14:36 -0300 MIME-Version: 1.0 In-Reply-To: <20180215042900.16078-16-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 15/30] hw/lm32: use the BYTE-based definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Walle On 02/15/2018 01:28 AM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. Forgot to add: Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/lm32_boards.c | 12 ++++++------ > hw/lm32/milkymist.c | 8 ++++---- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c > index 527bcc229c..15315101be 100644 > --- a/hw/lm32/lm32_boards.c > +++ b/hw/lm32/lm32_boards.c > @@ -88,10 +88,10 @@ static void lm32_evr_init(MachineState *machine) > > /* memory map */ > hwaddr flash_base = 0x04000000; > - size_t flash_sector_size = 256 * 1024; > - size_t flash_size = 32 * 1024 * 1024; > + size_t flash_sector_size = 256 * K_BYTE; > + size_t flash_size = 32 * M_BYTE; > hwaddr ram_base = 0x08000000; > - size_t ram_size = 64 * 1024 * 1024; > + size_t ram_size = 64 * M_BYTE; > hwaddr timer0_base = 0x80002000; > hwaddr uart0_base = 0x80006000; > hwaddr timer1_base = 0x8000a000; > @@ -174,10 +174,10 @@ static void lm32_uclinux_init(MachineState *machine) > > /* memory map */ > hwaddr flash_base = 0x04000000; > - size_t flash_sector_size = 256 * 1024; > - size_t flash_size = 32 * 1024 * 1024; > + size_t flash_sector_size = 256 * K_BYTE; > + size_t flash_size = 32 * M_BYTE; > hwaddr ram_base = 0x08000000; > - size_t ram_size = 64 * 1024 * 1024; > + size_t ram_size = 64 * M_BYTE; > hwaddr uart0_base = 0x80000000; > hwaddr timer0_base = 0x80002000; > hwaddr timer1_base = 0x80010000; > diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c > index c28379399f..b884b825bc 100644 > --- a/hw/lm32/milkymist.c > +++ b/hw/lm32/milkymist.c > @@ -36,7 +36,7 @@ > > #define BIOS_FILENAME "mmone-bios.bin" > #define BIOS_OFFSET 0x00860000 > -#define BIOS_SIZE (512*1024) > +#define BIOS_SIZE (512 * K_BYTE) > #define KERNEL_LOAD_ADDR 0x40000000 > > typedef struct { > @@ -95,10 +95,10 @@ milkymist_init(MachineState *machine) > > /* memory map */ > hwaddr flash_base = 0x00000000; > - size_t flash_sector_size = 128 * 1024; > - size_t flash_size = 32 * 1024 * 1024; > + size_t flash_sector_size = 128 * K_BYTE; > + size_t flash_size = 32 * M_BYTE; > hwaddr sdram_base = 0x40000000; > - size_t sdram_size = 128 * 1024 * 1024; > + size_t sdram_size = 128 * M_BYTE; > > hwaddr initrd_base = sdram_base + 0x1002000; > hwaddr cmdline_base = sdram_base + 0x1000000; >