* [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR)
@ 2021-01-12 11:29 Philippe Mathieu-Daudé
2021-01-12 12:21 ` Thomas Huth
2021-01-12 20:01 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-12 11:29 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Philippe Mathieu-Daudé, John Snow, qemu-block
Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/ide/ahci.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 4b675b9cfd8..6d50482b8d1 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr,
/* Only aligned reads are allowed on AHCI */
if (addr & 3) {
- fprintf(stderr, "ahci: Mis-aligned write to addr 0x"
- TARGET_FMT_plx "\n", addr);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX "\n",
+ addr);
return;
}
@@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
g_assert(is_ncq(ncq_fis->command));
if (ncq_tfs->used) {
/* error - already in use */
- fprintf(stderr, "%s: tag %d already used\n", __func__, tag);
+ qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n",
+ __func__, tag);
return;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR)
2021-01-12 11:29 [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Philippe Mathieu-Daudé
@ 2021-01-12 12:21 ` Thomas Huth
2021-01-12 20:01 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2021-01-12 12:21 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, John Snow, qemu-block
On 12/01/2021 12.29, Philippe Mathieu-Daudé wrote:
> Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/ide/ahci.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 4b675b9cfd8..6d50482b8d1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr,
>
> /* Only aligned reads are allowed on AHCI */
> if (addr & 3) {
> - fprintf(stderr, "ahci: Mis-aligned write to addr 0x"
> - TARGET_FMT_plx "\n", addr);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX "\n",
> + addr);
> return;
> }
>
> @@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
> g_assert(is_ncq(ncq_fis->command));
> if (ncq_tfs->used) {
> /* error - already in use */
> - fprintf(stderr, "%s: tag %d already used\n", __func__, tag);
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n",
> + __func__, tag);
> return;
> }
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR)
2021-01-12 11:29 [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Philippe Mathieu-Daudé
2021-01-12 12:21 ` Thomas Huth
@ 2021-01-12 20:01 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-01-12 20:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, John Snow, qemu-block
Le 12/01/2021 à 12:29, Philippe Mathieu-Daudé a écrit :
> Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/ide/ahci.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 4b675b9cfd8..6d50482b8d1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr,
>
> /* Only aligned reads are allowed on AHCI */
> if (addr & 3) {
> - fprintf(stderr, "ahci: Mis-aligned write to addr 0x"
> - TARGET_FMT_plx "\n", addr);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX "\n",
> + addr);
> return;
> }
>
> @@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
> g_assert(is_ncq(ncq_fis->command));
> if (ncq_tfs->used) {
> /* error - already in use */
> - fprintf(stderr, "%s: tag %d already used\n", __func__, tag);
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n",
> + __func__, tag);
> return;
> }
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-12 11:29 [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Philippe Mathieu-Daudé
2021-01-12 12:21 ` Thomas Huth
2021-01-12 20:01 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).