From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JoRUV-0007bP-Da
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 19:01:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JoRUS-0007b7-N2
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 19:01:34 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JoRUS-0007b2-Gw
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 19:01:32 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1JoRUR-0005G8-Si
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 19:01:32 -0400
Message-ID: <04a201c8a4cc$c5001620$0201a8c0@zeug>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <4804589A.6040300@reactos.org><00f701c8a329$97af64e0$0201a8c0@zeug><480BBD37.5010409@codemonkey.ws>
	<20080420231418.GA30932@redhat.com>
Date: Wed, 23 Apr 2008 01:00:26 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Add -display option
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org

From: "Daniel P. Berrange"
> On Sun, Apr 20, 2008 at 05:01:27PM -0500, Anthony Liguori wrote:
>> Sebastian Herbszt wrote:
>> >>I would better name it -display, as not all computers have 
>> >>VGA-compatible cards.
> 
>> >+                break;
>> >+            case QEMU_OPTION_display:
>> >+                if (!strcmp(optarg, "cirrus")) {
>> >+                    cirrus_vga_enabled = 1;
>> >+                    vmsvga_enabled = 0;
>> >+                } else if (!strcmp(optarg, "std")) {
>> >+                    cirrus_vga_enabled = 0;
>> >+                    vmsvga_enabled = 0;
>> >+                } else if (!strcmp(optarg, "vmware")) {
>> >+                    cirrus_vga_enabled = 0;
>> >+                    vmsvga_enabled = 1;
>> >+                } else if (!strcmp(optarg, "none")) {
>> >+                    serial_devices[0] = "stdio";
>> >+                    parallel_devices[0] = "null";
>> >+                    monitor_device = "stdio";
>> >+                    nographic = 1;
>> 
>> I don't think -display none should be a synonym for -nographic.  It 
>> should just suppress the creation of a VGA device.  If a platform 
>> doesn't support that, it should raise an error.
> 
> I agree - its rather unfortunate that -nographic changes the default
> settings for serial / parallel devices - it makes it troublesome to 
> launch QEMU with a predictable config. Having 'none' merely supress
> the VGA device would be preferrable behaviour.

Since i did not find that functionality yet, what would be the correct
implementation? Would adding an "int display_enabled = 1" in vl.c
suffice? With "-display none" display_enabled would be set to 0.
A platform not supporting it would then bail out with an error in its
init (e.g. pc_init1 from hw/pc.c).

- Sebastian