From: Richard Henderson <richard.henderson@linaro.org>
To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org
Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au,
groug@kaod.org
Subject: Re: [PATCH 11/12] target/ppc: declare vmsumuhm helper with call flags
Date: Tue, 17 May 2022 10:38:55 -0700 [thread overview]
Message-ID: <04aef0dc-befa-460f-aaeb-579b537b4bdd@linaro.org> (raw)
In-Reply-To: <20220517123929.284511-12-matheus.ferst@eldorado.org.br>
On 5/17/22 05:39, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> Move vmsumuhm and vmsumuhs to decodetree, declare vmsumuhm helper with
> TCG_CALL_NO_RWG, and drop the unused env argument.
>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
> target/ppc/helper.h | 4 ++--
> target/ppc/insn32.decode | 2 ++
> target/ppc/int_helper.c | 5 ++---
> target/ppc/translate/vmx-impl.c.inc | 24 ++++++++++++++++++++++--
> target/ppc/translate/vmx-ops.c.inc | 1 -
> 5 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> index f0761fe38d..5127851f2c 100644
> --- a/target/ppc/helper.h
> +++ b/target/ppc/helper.h
> @@ -242,8 +242,8 @@ DEF_HELPER_4(vpkudum, void, env, avr, avr, avr)
> DEF_HELPER_FLAGS_3(vpkpx, TCG_CALL_NO_RWG, void, avr, avr, avr)
> DEF_HELPER_5(vmhaddshs, void, env, avr, avr, avr, avr)
> DEF_HELPER_5(vmhraddshs, void, env, avr, avr, avr, avr)
> -DEF_HELPER_5(vmsumuhm, void, env, avr, avr, avr, avr)
> -DEF_HELPER_5(vmsumuhs, void, env, avr, avr, avr, avr)
> +DEF_HELPER_FLAGS_4(VMSUMUHM, TCG_CALL_NO_RWG, void, avr, avr, avr, avr)
> +DEF_HELPER_5(VMSUMUHS, void, env, avr, avr, avr, avr)
Actually, you can set NO_RWG for the second as well, because the only thing from env that
is modified is set_vscr_sat, which is not a TCG global.
r~
next prev parent reply other threads:[~2022-05-17 17:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:39 [PATCH 00/12] Change helper declarations to use call flags matheus.ferst
2022-05-17 12:39 ` [PATCH 01/12] target/ppc: declare darn32/darn64 helpers with TCG_CALL_NO_RWG matheus.ferst
2022-05-17 16:30 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 02/12] target/ppc: use TCG_CALL_NO_RWG in vector helpers without env matheus.ferst
2022-05-17 16:31 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 03/12] target/ppc: use TCG_CALL_NO_RWG in BCD helpers matheus.ferst
2022-05-17 16:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 04/12] target/ppc: use TCG_CALL_NO_RWG in VSX helpers without env matheus.ferst
2022-05-17 16:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 05/12] target/ppc: Use TCG_CALL_NO_RWG_SE in fsel helper matheus.ferst
2022-05-17 16:43 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 06/12] target/ppc: declare xscvspdpn helper with call flags matheus.ferst
2022-05-17 16:50 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 07/12] target/ppc: declare xvxsigsp " matheus.ferst
2022-05-17 17:30 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 08/12] target/ppc: declare xxextractuw and xxinsertw helpers " matheus.ferst
2022-05-17 17:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 09/12] target/ppc: introduce do_va_helper matheus.ferst
2022-05-17 17:33 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 10/12] target/ppc: declare vmsum[um]bm helpers with call flags matheus.ferst
2022-05-17 17:34 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 11/12] target/ppc: declare vmsumuhm helper " matheus.ferst
2022-05-17 17:37 ` Richard Henderson
2022-05-17 17:38 ` Richard Henderson [this message]
2022-05-17 12:39 ` [PATCH 12/12] target/ppc: declare vmsumshm " matheus.ferst
2022-05-17 17:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04aef0dc-befa-460f-aaeb-579b537b4bdd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).