From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h>
Date: Fri, 19 Jan 2018 09:30:48 +0100 [thread overview]
Message-ID: <04bf5c9b-3f7d-ba2f-3957-486c5b41719e@redhat.com> (raw)
In-Reply-To: <20180119081511.24010-1-clg@kaod.org>
On 19.01.2018 09:15, Cédric Le Goater wrote:
> This redefinition generates warnings on some clang compilers and older
> gcc4.4.
>
> ...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef 'PnvChip' is a C11
> feature [-Wtypedef-redefinition]
> typedef struct PnvChip PnvChip;
> ^
> ...include/hw/ppc/pnv.h:65:3: note: previous definition is here
> } PnvChip;
> ^
> 1 warning generated.
> CC ppc64-softmmu/hw/ppc/pnv_xscom.o
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/ppc/pnv_xscom.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index fb1bd5df095a..255b26a5aaf6 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,8 +21,6 @@
>
> #include "qom/object.h"
>
> -typedef struct PnvChip PnvChip;
> -
> typedef struct PnvXScomInterface {
> Object parent;
> } PnvXScomInterface;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-01-19 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 8:15 [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> Cédric Le Goater
2018-01-19 8:30 ` Thomas Huth [this message]
2018-01-21 9:44 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04bf5c9b-3f7d-ba2f-3957-486c5b41719e@redhat.com \
--to=thuth@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).