From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Laurent Vivier <laurent@vivier.eu>,
"Michael S. Tsirkin" <mst@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Zhao Liu <zhao1.liu@intel.com>,
kvm@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
Cameron Esfahani <dirty@apple.com>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-trivial@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Roman Bolshakov <rbolshakov@ddn.com>,
Phil Dennis-Jordan <phil@philjordan.eu>,
John Snow <jsnow@redhat.com>, Fabiano Rosas <farosas@suse.de>,
Gerd Hoffmann <kraxel@redhat.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v3 07/10] hw/i386/apic: Prefer APICCommonState over DeviceState
Date: Tue, 21 Oct 2025 17:57:32 +0200 [thread overview]
Message-ID: <04c7e205-80f3-4f24-aa78-a68c63d2af7a@linaro.org> (raw)
In-Reply-To: <20251019210303.104718-8-shentey@gmail.com>
On 19/10/25 23:03, Bernhard Beschow wrote:
> Makes the APIC API more type-safe by resolving quite a few APIC_COMMON
> downcasts.
Nice!
> Like PICCommonState, the APICCommonState is now a public typedef while staying
> an abstract datatype.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> include/hw/i386/apic.h | 33 +++++------
> include/hw/i386/apic_internal.h | 7 +--
> target/i386/cpu.h | 4 +-
> target/i386/kvm/kvm_i386.h | 2 +-
> target/i386/whpx/whpx-internal.h | 2 +-
> hw/i386/kvm/apic.c | 3 +-
> hw/i386/vapic.c | 2 +-
> hw/i386/x86-cpu.c | 2 +-
> hw/intc/apic.c | 97 +++++++++++++-------------------
> hw/intc/apic_common.c | 56 +++++++-----------
> target/i386/cpu-apic.c | 18 +++---
> target/i386/cpu-dump.c | 2 +-
> target/i386/cpu.c | 2 +-
> target/i386/kvm/kvm.c | 2 +-
> target/i386/whpx/whpx-apic.c | 3 +-
> 15 files changed, 95 insertions(+), 140 deletions(-)
> -int apic_get_highest_priority_irr(DeviceState *dev)
> +int apic_get_highest_priority_irr(APICCommonState *s)
> {
> - APICCommonState *s;
> -
> - if (!dev) {
> + if (!s) {
> /* no interrupts */
Pre-existing dubious check.
> return -1;
> }
> - s = APIC_COMMON(dev);
> return get_highest_priority_int(s->irr);
> }
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-10-21 15:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 21:02 [PATCH v3 00/10] Cleanup patches, mostly PC-related Bernhard Beschow
2025-10-19 21:02 ` [PATCH v3 01/10] hw/timer/i8254: Add I/O trace events Bernhard Beschow
2025-10-20 8:31 ` Philippe Mathieu-Daudé
2025-10-19 21:02 ` [PATCH v3 02/10] hw/audio/pcspk: " Bernhard Beschow
2025-10-20 8:29 ` Philippe Mathieu-Daudé
2025-10-19 21:02 ` [PATCH v3 03/10] hw/rtc/mc146818rtc: Convert CMOS_DPRINTF() into " Bernhard Beschow
2025-10-20 8:34 ` Philippe Mathieu-Daudé
2025-10-19 21:02 ` [PATCH v3 04/10] hw/rtc/mc146818rtc: Use ARRAY_SIZE macro Bernhard Beschow
2025-10-20 6:06 ` Philippe Mathieu-Daudé
2025-10-19 21:02 ` [PATCH v3 05/10] hw/rtc/mc146818rtc: Assert correct usage of mc146818rtc_set_cmos_data() Bernhard Beschow
2025-10-21 15:53 ` Philippe Mathieu-Daudé
2025-10-19 21:02 ` [PATCH v3 06/10] hw/ide/ide-internal: Move dma_buf_commit() into ide "namespace" Bernhard Beschow
2025-10-20 6:08 ` Philippe Mathieu-Daudé
2025-10-19 21:03 ` [PATCH v3 07/10] hw/i386/apic: Prefer APICCommonState over DeviceState Bernhard Beschow
2025-10-21 15:57 ` Philippe Mathieu-Daudé [this message]
2025-10-19 21:03 ` [PATCH v3 08/10] hw/i386/apic: Ensure own APIC use in apic_msr_{read, write} Bernhard Beschow
2025-10-20 6:09 ` Philippe Mathieu-Daudé
2025-10-20 17:22 ` Bernhard Beschow
2025-10-19 21:03 ` [PATCH v3 09/10] hw/intc/apic: Pass APICCommonState to apic_register_{read, write} Bernhard Beschow
2025-10-21 16:01 ` Philippe Mathieu-Daudé
2025-10-21 20:31 ` Philippe Mathieu-Daudé
2025-10-19 21:03 ` [PATCH v3 10/10] tests/qtest/ds1338-test: Reuse from_bcd() Bernhard Beschow
2025-10-20 6:11 ` Philippe Mathieu-Daudé
2025-10-21 16:07 ` [PATCH v3 00/10] Cleanup patches, mostly PC-related Philippe Mathieu-Daudé
2025-10-21 20:32 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c7e205-80f3-4f24-aa78-a68c63d2af7a@linaro.org \
--to=philmd@linaro.org \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phil@philjordan.eu \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).