From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC90ACCD1A7 for ; Tue, 21 Oct 2025 15:59:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBEk6-0002QV-4R; Tue, 21 Oct 2025 11:57:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBEk2-0002Iu-B1 for qemu-devel@nongnu.org; Tue, 21 Oct 2025 11:57:42 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBEjx-0007ul-RC for qemu-devel@nongnu.org; Tue, 21 Oct 2025 11:57:41 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46e6a6a5e42so31687045e9.0 for ; Tue, 21 Oct 2025 08:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761062254; x=1761667054; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EmsKfQPb+phFt2HKZnH8E/xSwMnb6ZMpj9GAaYtCOVo=; b=RlegZid1LrGl1NGudUsc+c8cPv2OW+BZ3sEySX63+OBjgXqMG6QdjACZN2uE3NUlYj vg6B1zDwhiTMPqlnZ2JfAJz58DhV8EV5QR5hr9OPFjluD2zHExAWVdV6hJPCS17eZrnZ BJhOdaCzQuZtnaoSiwjC/ixjZgpLOb5g/HTO8fV+M/M2/de3sem1M5zZlE/kNfH9M5k1 VMcbVEtJRQx8/4tWpmE6aP5M4F7jfVDzKe3BWK6hl2uSq+dQYn7N/zY1ZnCNfa4cHYNk 0l9lC32zF0OR2tZmeWVdkjRWryXUpru49raSHZ1qnLq0Nt98AMbsHXd3FrMSPhl8A8/U t4zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761062254; x=1761667054; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EmsKfQPb+phFt2HKZnH8E/xSwMnb6ZMpj9GAaYtCOVo=; b=mlGYetg1pXTmhFCLMymnG0Lkg1k3B6X4Ou8xgjUbUXfMRWKwYRzZ9Za6OJUyx9moBu 6FaOgUNevETIPrsG3B0f7FqR1yE4VzNuYiHLoSod9nDmlWYrZPuRlLD7fSEtFiG6Vp7V thrCsi8SvEaU2Kkc4iYJ8KhjsEq8LIY6sEVWbjNjPCUJYHRhX3CMwd1ctiWf4cfU3iCG AO5goljgZb8Qt3LfhzVRiVLmXwwM1yfSh1IHU61BHzANx/qSBX6Dh3r7WueSpCGjQGNM e9igvc5tVLZvBrFGrl0BnA94HJAdHK4o3Qo9j0F35vdtCrfpmhrbxHgyrHiVDUp+GKFE lJDQ== X-Forwarded-Encrypted: i=1; AJvYcCUNd8p8mD2O3jMwl5H9+L+s/rdAK7z9lvAhQixhm0NKEYgU4thb23caDYI6wqZlmIKV/wAZKeZosCm7@nongnu.org X-Gm-Message-State: AOJu0YzqMiQHbJ4DlJHALYOYQeYRj/rZJYJTvleJb0ATRyQjr5wP0UgZ HK0y/uiTssp6z+yfCrlxim6SlpCfBo6i9OhOOP1sua6eOzG0wt/3TcdYQNms7Tlty/w= X-Gm-Gg: ASbGnctPXkKMxK002NDr1SLxvmXItgUaFpJQBcTYRA1TYkfUMfOzWmhxLo2C5QfspU+ qtEMGDmNpLesVAbHEcvEz3ifX1ZQTP92Sb1mM/74jFUOPIuALUraAioLEK4HwEp4xAV6eL5ySEL sHb1FWwYkizRWrooER/V37P28Gf+usIcAS+w9pW9mn2ymKZ4ROC767JSl2pFm1UNCRvjR5+lmUs +SnWItctsAp5A2mJUQwqnDMQbnyjIJwwSo7dag3L9m/PQ8UhhORsNYTAVd/P85TCRExikfrKJPZ L/EF4ya6nCymtlzkEfJm0CkNXGJeUZwK0j2gCd2RdPIfDWkKGq7g1kxtFxjgch0nPBDOwqzTZ7G YB8+q1fgc48GJEaVc2++DwbtX+bh45n8hBHKu0PyrKHMHRFz1F4of85LFzDVvRwOAGT6wQwWke1 AQqbNE5HVsRPD7RRlPYW1HLsOSLWUEua1IvlvMiaTfpjtNDif7YYDJ9Q== X-Google-Smtp-Source: AGHT+IF1MmWzJKWbkzi17y79YgTkCd9mQLumlvX/g6V6H92HE0rBKfrbkoNhjBpfHnwGz+8efMIeKg== X-Received: by 2002:a05:600c:458b:b0:471:1702:f41a with SMTP id 5b1f17b1804b1-47117919f1bmr138586925e9.33.1761062254190; Tue, 21 Oct 2025 08:57:34 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47154d3843csm201798655e9.11.2025.10.21.08.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 08:57:33 -0700 (PDT) Message-ID: <04c7e205-80f3-4f24-aa78-a68c63d2af7a@linaro.org> Date: Tue, 21 Oct 2025 17:57:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] hw/i386/apic: Prefer APICCommonState over DeviceState Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Laurent Vivier , "Michael S. Tsirkin" , Eduardo Habkost , Zhao Liu , kvm@vger.kernel.org, Michael Tokarev , Cameron Esfahani , qemu-block@nongnu.org, Paolo Bonzini , qemu-trivial@nongnu.org, Laurent Vivier , Richard Henderson , Roman Bolshakov , Phil Dennis-Jordan , John Snow , Fabiano Rosas , Gerd Hoffmann , Sunil Muthuswamy , Marcelo Tosatti References: <20251019210303.104718-1-shentey@gmail.com> <20251019210303.104718-8-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251019210303.104718-8-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/10/25 23:03, Bernhard Beschow wrote: > Makes the APIC API more type-safe by resolving quite a few APIC_COMMON > downcasts. Nice! > Like PICCommonState, the APICCommonState is now a public typedef while staying > an abstract datatype. > > Signed-off-by: Bernhard Beschow > --- > include/hw/i386/apic.h | 33 +++++------ > include/hw/i386/apic_internal.h | 7 +-- > target/i386/cpu.h | 4 +- > target/i386/kvm/kvm_i386.h | 2 +- > target/i386/whpx/whpx-internal.h | 2 +- > hw/i386/kvm/apic.c | 3 +- > hw/i386/vapic.c | 2 +- > hw/i386/x86-cpu.c | 2 +- > hw/intc/apic.c | 97 +++++++++++++------------------- > hw/intc/apic_common.c | 56 +++++++----------- > target/i386/cpu-apic.c | 18 +++--- > target/i386/cpu-dump.c | 2 +- > target/i386/cpu.c | 2 +- > target/i386/kvm/kvm.c | 2 +- > target/i386/whpx/whpx-apic.c | 3 +- > 15 files changed, 95 insertions(+), 140 deletions(-) > -int apic_get_highest_priority_irr(DeviceState *dev) > +int apic_get_highest_priority_irr(APICCommonState *s) > { > - APICCommonState *s; > - > - if (!dev) { > + if (!s) { > /* no interrupts */ Pre-existing dubious check. > return -1; > } > - s = APIC_COMMON(dev); > return get_highest_priority_int(s->irr); > } Reviewed-by: Philippe Mathieu-Daudé