* Re: [PATCH] vhost-vsock: fix error message output
2020-03-01 12:03 [PATCH] vhost-vsock: fix error message output Nick Erdmann
@ 2020-03-02 10:29 ` Ján Tomko
2020-03-03 10:16 ` Laurent Vivier
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ján Tomko @ 2020-03-02 10:29 UTC (permalink / raw)
To: Nick Erdmann; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
On a Sunday in 2020, Nick Erdmann wrote:
>error_setg_errno takes a positive error number, so we should not invert
>errno's sign.
>
>Signed-off-by: Nick Erdmann <n@nirf.de>
>---
> hw/virtio/vhost-vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost-vsock: fix error message output
2020-03-01 12:03 [PATCH] vhost-vsock: fix error message output Nick Erdmann
2020-03-02 10:29 ` Ján Tomko
@ 2020-03-03 10:16 ` Laurent Vivier
2020-03-04 8:13 ` Stefano Garzarella
2020-03-06 12:56 ` Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2020-03-03 10:16 UTC (permalink / raw)
To: Nick Erdmann, qemu-devel; +Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi
Le 01/03/2020 à 13:03, Nick Erdmann a écrit :
> error_setg_errno takes a positive error number, so we should not invert
> errno's sign.
>
> Signed-off-by: Nick Erdmann <n@nirf.de>
> ---
> hw/virtio/vhost-vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c
> index 66da96583b..9f9093e196 100644
> --- a/hw/virtio/vhost-vsock.c
> +++ b/hw/virtio/vhost-vsock.c
> @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState
> *dev, Error **errp)
> } else {
> vhostfd = open("/dev/vhost-vsock", O_RDWR);
> if (vhostfd < 0) {
> - error_setg_errno(errp, -errno,
> + error_setg_errno(errp, errno,
> "vhost-vsock: failed to open vhost device");
> return;
> }
> --
> 2.25.1
>
Fixes: fc0b9b0e1cbb ("vhost-vsock: add virtio sockets device")
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost-vsock: fix error message output
2020-03-01 12:03 [PATCH] vhost-vsock: fix error message output Nick Erdmann
2020-03-02 10:29 ` Ján Tomko
2020-03-03 10:16 ` Laurent Vivier
@ 2020-03-04 8:13 ` Stefano Garzarella
2020-03-06 12:56 ` Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2020-03-04 8:13 UTC (permalink / raw)
To: Nick Erdmann; +Cc: qemu-trivial, qemu-devel
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote:
> error_setg_errno takes a positive error number, so we should not invert
> errno's sign.
>
> Signed-off-by: Nick Erdmann <n@nirf.de>
> ---
> hw/virtio/vhost-vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c
> index 66da96583b..9f9093e196 100644
> --- a/hw/virtio/vhost-vsock.c
> +++ b/hw/virtio/vhost-vsock.c
> @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState *dev, Error **errp)
> } else {
> vhostfd = open("/dev/vhost-vsock", O_RDWR);
> if (vhostfd < 0) {
> - error_setg_errno(errp, -errno,
> + error_setg_errno(errp, errno,
> "vhost-vsock: failed to open vhost device");
> return;
> }
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost-vsock: fix error message output
2020-03-01 12:03 [PATCH] vhost-vsock: fix error message output Nick Erdmann
` (2 preceding siblings ...)
2020-03-04 8:13 ` Stefano Garzarella
@ 2020-03-06 12:56 ` Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2020-03-06 12:56 UTC (permalink / raw)
To: Nick Erdmann; +Cc: qemu-trivial, qemu-devel, Michael S. Tsirkin
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote:
> error_setg_errno takes a positive error number, so we should not invert
> errno's sign.
>
> Signed-off-by: Nick Erdmann <n@nirf.de>
> ---
> hw/virtio/vhost-vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread