From: Max Reitz <mreitz@redhat.com>
To: Pan Nengyuan <pannengyuan@huawei.com>, kwolf@redhat.com
Cc: euler.robot@huawei.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH v2 0/2] fix two small memleaks
Date: Thu, 27 Feb 2020 16:24:23 +0100 [thread overview]
Message-ID: <04e239b7-606e-c2dd-b9cd-38662048557a@redhat.com> (raw)
In-Reply-To: <20200227012950.12256-1-pannengyuan@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 763 bytes --]
On 27.02.20 02:29, Pan Nengyuan wrote:
> This series fix two small memleaks.
> 1. 'crypto_opts' forgot to free in qcow2_close(), do this cleanup in qcow2_close();
> 2. Do free filename/format in collect_image_check() when we re-allocate it.
>
> v2->v1:
> - Instead of freeing part of fields in collect_image_check(), do discard the old check object and allocate a new one in the caller to make more sense.(suggested by Max Reitz)
>
> Pan Nengyuan (2):
> block/qcow2: do free crypto_opts in qcow2_close()
> qemu-img: free memory before re-assign
>
> block/qcow2.c | 1 +
> qemu-img.c | 2 ++
> 2 files changed, 3 insertions(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-27 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 1:29 [PATCH v2 0/2] fix two small memleaks Pan Nengyuan
2020-02-27 1:29 ` [PATCH v2 1/2] block/qcow2: do free crypto_opts in qcow2_close() Pan Nengyuan
2020-02-27 1:29 ` [PATCH v2 2/2] qemu-img: free memory before re-assign Pan Nengyuan
2020-02-27 15:24 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e239b7-606e-c2dd-b9cd-38662048557a@redhat.com \
--to=mreitz@redhat.com \
--cc=euler.robot@huawei.com \
--cc=kwolf@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).