From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Huacai Chen <chenhuacai@kernel.org>, John Snow <jsnow@redhat.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode
Date: Sun, 27 Dec 2020 15:16:07 +0100 [thread overview]
Message-ID: <04e85d26-fdb4-07f0-1fac-afc4aa7dbc83@amsat.org> (raw)
In-Reply-To: <47c59c404e979f6ad2eaf2be776f1a56cabe7671.1608852217.git.balaton@eik.bme.hu>
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
> We'll need a flag for implementing some device specific behaviour in
> via-ide but we already have a currently CMD646 specific field that can
> be repurposed for this and leave room for furhter flags if needed in
> the future. This patch changes the "secondary" field to "flags" and
> change CMD646 and its users accordingly and define a new flag for
> forcing legacy mode that will be used by via-ide for now.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ide/cmd646.c | 4 ++--
> hw/sparc64/sun4u.c | 2 +-
> include/hw/ide/pci.h | 7 ++++++-
> 3 files changed, 9 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2020-12-27 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 23:23 [PATCH 0/2] Fix via-ide for fuloong2e BALATON Zoltan via
2020-12-24 23:23 ` [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode BALATON Zoltan via
2020-12-27 14:16 ` Philippe Mathieu-Daudé [this message]
2020-12-24 23:23 ` [PATCH 2/2] via-ide: Fix fuloong2e support BALATON Zoltan via
2020-12-27 15:18 ` Philippe Mathieu-Daudé
2020-12-27 16:40 ` BALATON Zoltan via
2020-12-27 17:24 ` Philippe Mathieu-Daudé
2020-12-27 17:43 ` Guenter Roeck
2020-12-27 22:27 ` BALATON Zoltan via
-- strict thread matches above, loose matches on Subject: below --
2020-12-25 0:37 [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e85d26-fdb4-07f0-1fac-afc4aa7dbc83@amsat.org \
--to=f4bug@amsat.org \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=jsnow@redhat.com \
--cc=linux@roeck-us.net \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).