From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-thread: avoid false positive in pthread_cleanup_push
Date: Wed, 8 Sep 2021 07:58:34 +0200 [thread overview]
Message-ID: <04eec17e-52bc-88a9-3278-7f2a97a83cd8@redhat.com> (raw)
In-Reply-To: <477f7de5-7977-4dd5-38e8-8130149e3570@linaro.org>
On 07/09/21 16:20, Richard Henderson wrote:
> On 9/7/21 2:51 PM, Paolo Bonzini wrote:
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wstringop-overflow"
>> pthread_cleanup_push(qemu_thread_atexit_notify, NULL);
>> +#pragma GCC diagnostic pop
>
> I had a patch for this that didn't quite get applied for 6.1.
> You can't leave the pragma unprotected for clang, unfortunately.
>
> https://patchew.org/QEMU/20210803211907.150525-1-richard.henderson@linaro.org/
Thanks! I queued your patch instead of mine.
Paolo
prev parent reply other threads:[~2021-09-08 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:51 [PATCH] qemu-thread: avoid false positive in pthread_cleanup_push Paolo Bonzini
2021-09-07 14:20 ` Richard Henderson
2021-09-08 5:58 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04eec17e-52bc-88a9-3278-7f2a97a83cd8@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).