From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org,
"Alistair Francis" <alistair@alistair23.me>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
Date: Wed, 22 Jan 2020 08:19:48 +0100 [thread overview]
Message-ID: <05208ecf-9d8f-7dfc-ea95-974e93aa49b5@redhat.com> (raw)
In-Reply-To: <20200121213853.9601-1-f4bug@amsat.org>
On 21/01/2020 22.38, Philippe Mathieu-Daudé wrote:
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-01-22 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 21:38 [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error Philippe Mathieu-Daudé
2020-01-21 22:19 ` Alistair Francis
2020-01-22 7:19 ` Thomas Huth [this message]
2020-01-22 10:26 ` Alex Bennée
2020-01-23 14:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05208ecf-9d8f-7dfc-ea95-974e93aa49b5@redhat.com \
--to=thuth@redhat.com \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).