From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: tony.nguyen@bt.com, qemu-devel@nongnu.org
Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com,
dmitry.fleytman@gmail.com, sagark@eecs.berkeley.edu,
mst@redhat.com, green@moxielogic.com, palmer@sifive.com,
mark.cave-ayland@ilande.co.uk, keith.busch@intel.com,
jcmvbkbc@gmail.com, frederic.konrad@adacore.com,
pbonzini@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com,
mreitz@redhat.com, pburton@wavecomp.com, marex@denx.de,
robh@kernel.org, hare@suse.com, gxt@mprc.pku.edu.cn,
berto@igalia.com, proljc@gmail.com, qemu-block@nongnu.org,
arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de,
david@redhat.com, magnus.damm@gmail.com, yuval.shaia@oracle.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com,
marcandre.lureau@redhat.com, david@gibson.dropbear.id.au,
jasowang@redhat.com, atar4qemu@gmail.com,
antonynpavlov@gmail.com, jiri@resnulli.us, ehabkost@redhat.com,
minyard@acm.org, jcd@tribudubois.net, sw@weilnetz.de,
alistair@alistair23.me, chouteau@adacore.com,
b.galvani@gmail.com, eric.auger@redhat.com,
alex.williamson@redhat.com, sstabellini@kernel.org,
jan.kiszka@web.de, clg@kaod.org, stefanha@redhat.com,
imammedo@redhat.com, xen-devel@lists.xenproject.org,
shorne@gmail.com, andrew.smirnov@gmail.com, jsnow@redhat.com,
rth@twiddle.net, kwolf@redhat.com, qemu-s390x@nongnu.org,
qemu-arm@nongnu.org, xiaoguangrong.eric@gmail.com,
qemu-riscv@nongnu.org, andrew@aj.id.au, lersek@redhat.com,
crwulff@gmail.com, laurent@vivier.eu,
Andrew.Baumann@microsoft.com, sundeep.lkml@gmail.com,
i.mitsyanko@gmail.com, michael@walle.cc, paul.durrant@citrix.com,
qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com,
kbastian@mail.uni-paderborn.de, cohuck@redhat.com,
peter.chubb@nicta.com.au, aurelien@aurel32.net,
stefanb@linux.ibm.com
Subject: Re: [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE
Date: Wed, 7 Aug 2019 14:54:40 +0200 [thread overview]
Message-ID: <0523c403-bdae-bb5d-8996-20b57cd5d7cf@redhat.com> (raw)
In-Reply-To: <1565181666201.26324@bt.com>
On 8/7/19 2:41 PM, tony.nguyen@bt.com wrote:
> On 8/7/19 8:37 PM, Philippe Mathieu-Daudé wrote:
>
>> I'm confused I think I already reviewed various patches of your previous
> > series but don't see my Reviewed-by tags.>
> Apologies Philippe! I am the confused one here =/
>
> Will append.
>
> Thank you very much for the reviews and qemu-devel newbie tips so far. I
> have felt very welcome.
Well for a newbie you did an impressive series!
The 'Reviewed-by' or 'Tested-by' tags help the maintainers to process
patches.
Since reviewing a series is time-consuming, if you iterate over a series
without changing some patchs, you should collect and amend the tags the
reviewers gave you, this way it helps them keep track of patches
reviewed and patches waiting for review.
In my case I find it very confuse when I look at a patch I already gave
my R-b tag and the tag is not here, I re-review the patch looking for
differences.
Often a reviewer asks for easy changes, and uses "with this changes:
R-b". If you addresses his comments you can then add his tag in the next
version.
If you split a reviewed patch in various, it is also OK to keep the tags
in all the splitted patches.
Regards,
Phil.
prev parent reply other threads:[~2019-08-07 12:55 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:23 [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE tony.nguyen
2019-08-07 8:25 ` [Qemu-devel] [PATCH v6 01/26] configure: Define TARGET_ALIGNED_ONLY tony.nguyen
2019-08-08 14:08 ` Cornelia Huck
2019-08-07 8:26 ` [Qemu-devel] [PATCH v6 02/26] tcg: TCGMemOp is now accelerator independent MemOp tony.nguyen
2019-08-08 14:14 ` Cornelia Huck
2019-08-07 8:26 ` [Qemu-devel] [PATCH v6 03/26] memory: Introduce size_memop tony.nguyen
2019-08-07 15:30 ` Richard Henderson
2019-08-07 8:27 ` [Qemu-devel] [PATCH v6 04/26] target/mips: Access MemoryRegion with MemOp tony.nguyen
2019-08-07 12:50 ` tony.nguyen
2019-08-07 8:27 ` [Qemu-devel] [PATCH v6 05/26] hw/s390x: " tony.nguyen
2019-08-08 14:31 ` Cornelia Huck
2019-08-07 8:27 ` [Qemu-devel] [PATCH v6 06/26] hw/intc/armv7m_nic: " tony.nguyen
2019-08-07 12:54 ` tony.nguyen
2019-08-07 8:28 ` [Qemu-devel] [PATCH v6 07/26] hw/virtio: " tony.nguyen
2019-08-08 14:32 ` Cornelia Huck
2019-08-07 8:28 ` [Qemu-devel] [PATCH v6 08/26] hw/vfio: " tony.nguyen
2019-08-08 14:34 ` Cornelia Huck
2019-08-07 8:28 ` [Qemu-devel] [PATCH v6 09/26] exec: " tony.nguyen
2019-08-07 12:56 ` tony.nguyen
2019-08-07 8:29 ` [Qemu-devel] [PATCH v6 10/26] cputlb: " tony.nguyen
2019-08-07 12:45 ` tony.nguyen
2019-08-07 15:32 ` Richard Henderson
2019-08-07 8:29 ` [Qemu-devel] [PATCH v6 11/26] memory: " tony.nguyen
2019-08-07 15:38 ` Richard Henderson
2019-08-07 8:30 ` [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64} tony.nguyen
2019-08-07 15:47 ` Richard Henderson
2019-08-08 14:44 ` Cornelia Huck
2019-08-07 8:30 ` [Qemu-devel] [PATCH v6 13/26] target/mips: " tony.nguyen
2019-08-07 15:47 ` Richard Henderson
2019-08-07 8:30 ` [Qemu-devel] [PATCH v6 14/26] exec: " tony.nguyen
2019-08-07 15:48 ` Richard Henderson
2019-08-07 8:31 ` [Qemu-devel] [PATCH v6 15/26] build: Correct non-common common-obj-* to obj-* tony.nguyen
2019-08-07 10:42 ` Paolo Bonzini
2019-08-07 8:31 ` [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp tony.nguyen
2019-08-07 15:55 ` Richard Henderson
2019-08-07 15:59 ` Richard Henderson
2019-08-07 16:06 ` Richard Henderson
2019-08-07 8:31 ` [Qemu-devel] [PATCH v6 17/26] exec: Replace device_endian with MemOp tony.nguyen
2019-08-07 16:23 ` Richard Henderson
2019-08-09 0:35 ` David Gibson
2019-08-07 8:32 ` [Qemu-devel] [PATCH v6 18/26] exec: Delete device_endian tony.nguyen
2019-08-07 16:23 ` Richard Henderson
2019-08-07 8:32 ` [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN tony.nguyen
2019-08-07 10:22 ` Paolo Bonzini
2019-08-07 15:03 ` Richard Henderson
2019-08-07 8:33 ` [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness tony.nguyen
2019-08-07 10:27 ` Paolo Bonzini
2019-08-07 17:49 ` Richard Henderson
2019-08-07 18:00 ` Paolo Bonzini
2019-08-07 18:23 ` Richard Henderson
2019-08-07 8:33 ` [Qemu-devel] [PATCH v6 21/26] cputlb: Replace size and endian operands for MemOp tony.nguyen
2019-08-07 17:38 ` Richard Henderson
2019-08-07 8:34 ` [Qemu-devel] [PATCH v6 22/26] memory: Single byte swap along the I/O path tony.nguyen
2019-08-07 8:34 ` [Qemu-devel] [PATCH v6 23/26] cpu: TLB_FLAGS_MASK bit to force memory slow path tony.nguyen
2019-08-07 8:34 ` [Qemu-devel] [PATCH v6 24/26] cputlb: Byte swap memory transaction attribute tony.nguyen
2019-08-07 8:35 ` [Qemu-devel] [PATCH v6 25/26] target/sparc: Add TLB entry with attributes tony.nguyen
2019-08-07 8:35 ` [Qemu-devel] [PATCH v6 26/26] target/sparc: sun4u Invert Endian TTE bit tony.nguyen
2019-08-07 13:04 ` tony.nguyen
2019-08-07 10:37 ` [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE Philippe Mathieu-Daudé
2019-08-07 12:41 ` tony.nguyen
2019-08-07 12:54 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0523c403-bdae-bb5d-8996-20b57cd5d7cf@redhat.com \
--to=philmd@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=alex.williamson@redhat.com \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@aj.id.au \
--cc=anthony.perard@citrix.com \
--cc=antonynpavlov@gmail.com \
--cc=arikalo@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=berto@igalia.com \
--cc=borntraeger@de.ibm.com \
--cc=chouteau@adacore.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=dmitry.fleytman@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=frederic.konrad@adacore.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hare@suse.com \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=i.mitsyanko@gmail.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=jiri@resnulli.us \
--cc=joel@jms.id.au \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=lersek@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pasic@linux.ibm.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=sundeep.lkml@gmail.com \
--cc=sw@weilnetz.de \
--cc=tony.nguyen@bt.com \
--cc=walling@linux.ibm.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).