From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
qemu-trivial@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] hw/s390x/css: Remove double initialization
Date: Mon, 7 Sep 2020 13:43:17 +0200 [thread overview]
Message-ID: <0529dba0-435e-ab3d-d7c6-7100df4c86c3@redhat.com> (raw)
In-Reply-To: <20200907024020.854465-1-philmd@redhat.com>
On 07/09/2020 04.40, Philippe Mathieu-Daudé wrote:
> Fix eventual copy/paste mistake introduced in commit bc994b74ea
> ("s390x/css: Use static initialization for channel_subsys fields").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/s390x/css.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 519dc91316d..9961cfe7bf6 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
> .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
> .do_crw_mchk = true,
> .sei_pending = false,
> - .do_crw_mchk = true,
> .crws_lost = false,
> .chnmon_active = false,
> .indicator_addresses =
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-09-07 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 2:40 [PATCH] hw/s390x/css: Remove double initialization Philippe Mathieu-Daudé
2020-09-07 11:43 ` Thomas Huth [this message]
2020-09-09 10:01 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0529dba0-435e-ab3d-d7c6-7100df4c86c3@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).