From: Richard Henderson <rth@twiddle.net>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
david@gibson.dropbear.id.au
Cc: alex.bennee@linaro.org, peter.maydell@linaro.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC] configure: fix clang failure for libatomic
Date: Tue, 25 Apr 2017 11:41:52 +0200 [thread overview]
Message-ID: <052c8b5a-5056-5867-c4c8-11a8735d69a5@twiddle.net> (raw)
In-Reply-To: <20170425083555.13547-1-nikunj@linux.vnet.ibm.com>
On 04/25/2017 10:35 AM, Nikunj A Dadhania wrote:
> if compile_prog "" "" ; then
> atomic128=yes
> + elif compile_prog "" "-latomic" ; then
> + atomic128=yes
> + lib_atomic="-latomic"
> fi
This is a problem, because I think you'll find that gcc now advertises
CONFIG_ATOMIC128 for *all* hosts.
This is because by definition, libatomic supplies fallback routines for types
of arbitrary size. However, the fallback routines use locking, not actual
atomic operations. So the configure test is no longer testing what we intended.
r~
prev parent reply other threads:[~2017-04-25 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 8:35 [Qemu-devel] [PATCH RFC] configure: fix clang failure for libatomic Nikunj A Dadhania
2017-04-25 8:42 ` Peter Maydell
2017-04-25 8:58 ` Nikunj A Dadhania
2017-04-25 9:04 ` Peter Maydell
2017-04-25 9:16 ` Nikunj A Dadhania
2017-04-25 9:32 ` Peter Maydell
2017-04-25 9:41 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=052c8b5a-5056-5867-c4c8-11a8735d69a5@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).