* [PATCH] tests/avocado: Remove p7zip binary availability check
@ 2021-11-06 9:10 Philippe Mathieu-Daudé
2021-11-08 12:00 ` Joaquin de Andres
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-06 9:10 UTC (permalink / raw)
To: qemu-devel
Cc: Wainer dos Santos Moschetta, Willian Rampazzo, Niek Linnenbank,
qemu-arm, Cleber Rosa, Philippe Mathieu-Daudé
The single use of the 7z binary has been removed in commit a30e114f3
("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
we don't need to check for this binary availability anymore.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20211105155354.154864-1-willianr@redhat.com>
---
tests/avocado/boot_linux_console.py | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index 4ed01ed7893..9c618d4809f 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -22,13 +22,6 @@
from avocado_qemu import wait_for_console_pattern
from avocado.utils import process
from avocado.utils import archive
-from avocado.utils.path import find_command, CmdNotFoundError
-
-P7ZIP_AVAILABLE = True
-try:
- find_command('7z')
-except CmdNotFoundError:
- P7ZIP_AVAILABLE = False
"""
Round up to next power of 2
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: Remove p7zip binary availability check
2021-11-06 9:10 [PATCH] tests/avocado: Remove p7zip binary availability check Philippe Mathieu-Daudé
@ 2021-11-08 12:00 ` Joaquin de Andres
2021-11-08 12:29 ` Willian Rampazzo
2021-11-08 15:49 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Joaquin de Andres @ 2021-11-08 12:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Willian Rampazzo, Niek Linnenbank, qemu-arm,
Wainer dos Santos Moschetta, Cleber Rosa
On 11/6/21 10:10, Philippe Mathieu-Daudé wrote:
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
> tests/avocado/boot_linux_console.py | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
> index 4ed01ed7893..9c618d4809f 100644
> --- a/tests/avocado/boot_linux_console.py
> +++ b/tests/avocado/boot_linux_console.py
> @@ -22,13 +22,6 @@
> from avocado_qemu import wait_for_console_pattern
> from avocado.utils import process
> from avocado.utils import archive
> -from avocado.utils.path import find_command, CmdNotFoundError
> -
> -P7ZIP_AVAILABLE = True
> -try:
> - find_command('7z')
> -except CmdNotFoundError:
> - P7ZIP_AVAILABLE = False
>
> """
> Round up to next power of 2
>
Reviewed-by: Joaquin de Andres <me@xcancerberox.com.ar>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: Remove p7zip binary availability check
2021-11-06 9:10 [PATCH] tests/avocado: Remove p7zip binary availability check Philippe Mathieu-Daudé
2021-11-08 12:00 ` Joaquin de Andres
@ 2021-11-08 12:29 ` Willian Rampazzo
2021-11-08 15:49 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Willian Rampazzo @ 2021-11-08 12:29 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Niek Linnenbank, qemu-arm, qemu-devel,
Wainer dos Santos Moschetta, Cleber Rosa
On Sat, Nov 6, 2021 at 3:14 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
> tests/avocado/boot_linux_console.py | 7 -------
> 1 file changed, 7 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: Remove p7zip binary availability check
2021-11-06 9:10 [PATCH] tests/avocado: Remove p7zip binary availability check Philippe Mathieu-Daudé
2021-11-08 12:00 ` Joaquin de Andres
2021-11-08 12:29 ` Willian Rampazzo
@ 2021-11-08 15:49 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-08 15:49 UTC (permalink / raw)
To: qemu-devel
Cc: Willian Rampazzo, Niek Linnenbank, qemu-arm,
Wainer dos Santos Moschetta, Cleber Rosa
On 11/6/21 10:10, Philippe Mathieu-Daudé wrote:
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
> tests/avocado/boot_linux_console.py | 7 -------
> 1 file changed, 7 deletions(-)
Patch queued to avocado-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-08 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-06 9:10 [PATCH] tests/avocado: Remove p7zip binary availability check Philippe Mathieu-Daudé
2021-11-08 12:00 ` Joaquin de Andres
2021-11-08 12:29 ` Willian Rampazzo
2021-11-08 15:49 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).