From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb: fix libusb config variable name.
Date: Tue, 26 Sep 2017 09:16:29 +0200 [thread overview]
Message-ID: <053ad89e-9084-905e-a6cd-4a1f4c4638e8@siemens.com> (raw)
In-Reply-To: <20170926063820.30773-1-kraxel@redhat.com>
On 2017-09-26 08:38, Gerd Hoffmann wrote:
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> index 9255234c63..0e6d54b21f 100644
> --- a/hw/usb/Makefile.objs
> +++ b/hw/usb/Makefile.objs
> @@ -42,7 +42,7 @@ redirect.o-cflags = $(USB_REDIR_CFLAGS)
> redirect.o-libs = $(USB_REDIR_LIBS)
>
> # usb pass-through
> -ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)
> +ifeq ($(CONFIG_USB_LIBUSB)$(CONFIG_USB),yy)
> common-obj-y += host-libusb.o host-legacy.o
> else
> common-obj-y += host-stub.o
>
This won't still work, only patch did -> CONFIG_USB isn't set when
building the common objects.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-09-26 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 6:38 [Qemu-devel] [PATCH] usb: fix libusb config variable name Gerd Hoffmann
2017-09-26 7:16 ` Jan Kiszka [this message]
2017-09-26 7:21 ` Gerd Hoffmann
2017-09-26 8:06 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053ad89e-9084-905e-a6cd-4a1f4c4638e8@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).