qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: matheus.ferst@eldorado.org.br,
	Luis Pires <luis.pires@eldorado.org.br>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH] target/ppc: fix single-step exception regression
Date: Wed, 2 Jun 2021 08:50:26 -0700	[thread overview]
Message-ID: <05523c8f-e564-2f61-5a39-eccac11c4f53@linaro.org> (raw)
In-Reply-To: <YLdHZuIlK4VEBlWf@yekko>

On 6/2/21 1:55 AM, David Gibson wrote:
> On Tue, Jun 01, 2021 at 01:27:20PM -0700, Richard Henderson wrote:
>> On 6/1/21 11:02 AM, Luis Pires wrote:
>>> +            if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) {
>>> +                /* We have not updated nip yet, so do it now */
>>> +                gen_update_nip(ctx, nip);
>>> +            }
>>
>> This is incorrect.  Both EXIT and CHAIN *have* updated nip, but to something
>> that isn't the next instruction.  E.g. return from interrupt.
> 
> Any theories on what's actually causing the regression, then?
> 

I would have thought the first hunk would have some effect.  But otherwise this 
is the first I've heard of the problem.  Description?  Reproduction instruction?


r~


  reply	other threads:[~2021-06-02 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 18:02 [PATCH] target/ppc: fix single-step exception regression Luis Pires
2021-06-01 20:27 ` Richard Henderson
2021-06-02  8:55   ` David Gibson
2021-06-02 15:50     ` Richard Henderson [this message]
2021-06-02 17:13       ` Luis Fernando Fujita Pires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05523c8f-e564-2f61-5a39-eccac11c4f53@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=luis.pires@eldorado.org.br \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).