From: Thomas Huth <thuth@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/5] bios-tables-test: fix path to allowed diff
Date: Wed, 22 Jan 2020 10:18:30 +0100 [thread overview]
Message-ID: <0557a86b-0088-667b-cbf2-410fee2488e2@redhat.com> (raw)
In-Reply-To: <20200122080538.591734-5-mst@redhat.com>
On 22/01/2020 09.06, Michael S. Tsirkin wrote:
> Fixes: 1e8a1fae7464 ("test: Move qtests to a separate directory")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 6ec1c5be64..6535ab7f04 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -21,7 +21,7 @@
> * in binary commit created in step 6):
> *
> * After 1-3 above tests will pass but ignore differences with the expected files.
> - * You will also notice that tests/bios-tables-test-allowed-diff.h lists
> + * You will also notice that tests/qtest/bios-tables-test-allowed-diff.h lists
> * a bunch of files. This is your hint that you need to do the below:
> * 4. Run
> * make check V=1
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-01-22 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 8:05 [PATCH 0/5] bios-tables-test: more documentation Michael S. Tsirkin
2020-01-22 8:05 ` [PATCH 1/5] bios-tables-test: tell people how to update Michael S. Tsirkin
2020-01-22 8:25 ` Laurent Vivier
2020-01-22 9:17 ` Thomas Huth
2020-01-22 8:05 ` [PATCH 2/5] bios-tables-test: fix up DIFF generation Michael S. Tsirkin
2020-01-22 9:00 ` Laurent Vivier
2020-01-22 9:13 ` Michael S. Tsirkin
2020-01-22 8:05 ` [PATCH 3/5] bios-tables-test: default diff command Michael S. Tsirkin
2020-01-22 8:06 ` [PATCH 4/5] bios-tables-test: fix path to allowed diff Michael S. Tsirkin
2020-01-22 8:51 ` Laurent Vivier
2020-01-22 9:18 ` Thomas Huth [this message]
2020-01-22 8:06 ` [PATCH 5/5] rebuild-expected-aml.sh: remind about the process Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0557a86b-0088-667b-cbf2-410fee2488e2@redhat.com \
--to=thuth@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).