[PATCH] docs/about/removed-features: Clarify 'device_add' is removed

[PATCH] docs/about/removed-features: Clarify 'device_add' is removed

[Philippe Mathieu-Daudé]

All other titles in removed-features.rst mention when
the feature was removed using "removed in". Use that
instead of "since" which we use for when a feature is
deprecated.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 docs/about/removed-features.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
index 25a904032c5..00e248de60b 100644
--- a/docs/about/removed-features.rst
+++ b/docs/about/removed-features.rst
@@ -730,8 +730,8 @@ Use ``multifd-channels`` instead.
 
 Use ``multifd-compression`` instead.
 
-Incorrectly typed ``device_add`` arguments (since 9.2)
-''''''''''''''''''''''''''''''''''''''''''''''''''''''
+Incorrectly typed ``device_add`` arguments (removed in 9.2)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
 Due to shortcomings in the internal implementation of ``device_add``,
 QEMU used to incorrectly accept certain invalid arguments. Any object
-- 
2.51.0

Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed

[Daniel P. Berrangé]

On Mon, Sep 01, 2025 at 01:39:56PM +0200, Philippe Mathieu-Daudé wrote:
> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  docs/about/removed-features.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

My bad.

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed

[Philippe Mathieu-Daudé]

On 1/9/25 13:39, Philippe Mathieu-Daudé wrote:
> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   docs/about/removed-features.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Patch queued, thanks.