From: Richard Henderson <richard.henderson@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
laurent@vivier.eu, lucienmp.qemu@gmail.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_M68K
Date: Mon, 19 Sep 2022 10:15:51 +0200 [thread overview]
Message-ID: <056d6f5d-c978-afec-dbc0-e0a12ec0e8c4@linaro.org> (raw)
In-Reply-To: <20220917112515.83905-2-mark.cave-ayland@ilande.co.uk>
On 9/17/22 13:25, Mark Cave-Ayland wrote:
> The M68K_FEATURE_M68000 feature is misleading in that its name suggests the feature
> is defined just for Motorola 68000 CPUs, whilst in fact it is defined for all
> Motorola 680X0 CPUs.
>
> In order to avoid confusion with the other M68K_FEATURE_M680X0 constants which
> define the features available for specific Motorola CPU models, rename
> M68K_FEATURE_M68000 to M68K_FEATURE_M68K and add comments to clarify its usage.
>
> Signed-off-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
> ---
> target/m68k/cpu.c | 2 +-
> target/m68k/cpu.h | 5 +-
> target/m68k/helper.c | 2 +-
> target/m68k/op_helper.c | 2 +-
> target/m68k/translate.c | 138 ++++++++++++++++++++--------------------
> 5 files changed, 75 insertions(+), 74 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-09-19 8:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 11:25 [PATCH 0/4] target/m68k: MacOS supervisor/user mode switch fixes Mark Cave-Ayland
2022-09-17 11:25 ` [PATCH 1/4] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_M68K Mark Cave-Ayland
2022-09-17 22:21 ` Philippe Mathieu-Daudé via
2022-09-19 8:15 ` Richard Henderson [this message]
2022-09-21 13:04 ` Laurent Vivier
2022-09-17 11:25 ` [PATCH 2/4] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t Mark Cave-Ayland
2022-09-17 12:09 ` BALATON Zoltan
2022-09-17 22:27 ` Philippe Mathieu-Daudé via
2022-09-20 16:30 ` Mark Cave-Ayland
2022-09-20 16:34 ` Philippe Mathieu-Daudé via
2022-09-20 19:01 ` BALATON Zoltan
2022-09-21 13:14 ` Laurent Vivier
2022-09-20 16:25 ` Mark Cave-Ayland
2022-09-17 11:25 ` [PATCH 3/4] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check Mark Cave-Ayland
2022-09-19 8:15 ` Richard Henderson
2022-09-17 11:25 ` [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR Mark Cave-Ayland
2022-09-17 22:29 ` Philippe Mathieu-Daudé via
2022-09-19 8:13 ` Richard Henderson
2022-09-20 17:47 ` Philippe Mathieu-Daudé via
2022-09-19 8:13 ` Richard Henderson
2022-09-21 13:11 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056d6f5d-c978-afec-dbc0-e0a12ec0e8c4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=lucienmp.qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).