Re: [PULL 12/40] rust: build integration test for the qemu_api crate

[Paolo Bonzini <pbonzini@redhat.com>]

On 12/19/24 10:53, Bernhard Beschow wrote:
> 
> 
> Am 4. November 2024 17:26:51 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>:
>> Adjust the integration test to compile with a subset of QEMU object
>> files, and make it actually create an object of the class it defines.
>>
>> Follow the Rust filesystem conventions, where tests go in tests/ if
>> they use the library in the same way any other code would.
>>
>> Reviewed-by: Junjie Mao <junjie.mao@hotmail.com>
>> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> meson.build                  | 10 ++++-
>> rust/qemu-api/meson.build    | 26 ++++++++++--
>> rust/qemu-api/src/lib.rs     |  3 --
>> rust/qemu-api/src/tests.rs   | 49 ----------------------
>> rust/qemu-api/tests/tests.rs | 78 ++++++++++++++++++++++++++++++++++++
>> 5 files changed, 110 insertions(+), 56 deletions(-)
>> delete mode 100644 rust/qemu-api/src/tests.rs
>> create mode 100644 rust/qemu-api/tests/tests.rs
> 
> When `--enable-modules` is passed to configure, this patch results in numerous undefined symbols.

Thanks for the report... This doesn't seem easy to fix without adding 
more hacks on top, but I'll try to do it right.

Paolo