From: Laurent Vivier <laurent@vivier.eu>
To: chengang@emindsoft.com.cn, rth@twiddle.net,
peter.maydell@linaro.org, cmetcalf@ezchip.com,
edgar.iglesias@gmail.com
Cc: walt@tilera.com, riku.voipio@iki.fi, qemu-devel@nongnu.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer
Date: Wed, 4 May 2016 19:46:26 +0200 [thread overview]
Message-ID: <05a2f0bd-67ac-c40c-b76d-067632d8d656@vivier.eu> (raw)
In-Reply-To: <1459260825-5710-1-git-send-email-chengang@emindsoft.com.cn>
Le 29/03/2016 à 16:13, chengang@emindsoft.com.cn a écrit :
> From: Chen Gang <chengang@emindsoft.com.cn>
>
> The return address is in target space, so the restorer address needs to
> be target space, too.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> linux-user/signal.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 4157154..c0a6f7e 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -3532,7 +3532,8 @@ static void setup_frame(int sig, struct target_sigaction *ka,
>
> /* Return from sighandler will jump to the tramp.
> Negative 8 offset because return is rtsd r15, 8 */
> - env->regs[15] = ((unsigned long)frame->tramp) - 8;
> + env->regs[15] = frame_addr + offsetof(struct target_signal_frame, tramp)
> + - 8;
> }
>
> /* Set up registers for signal handler */
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
prev parent reply other threads:[~2016-05-04 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 14:13 [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer chengang
2016-05-04 16:05 ` Peter Maydell
2016-05-05 14:48 ` Chen Gang
2016-05-05 16:11 ` Edgar E. Iglesias
2016-05-14 3:19 ` Chen Gang
2016-05-04 17:46 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a2f0bd-67ac-c40c-b76d-067632d8d656@vivier.eu \
--to=laurent@vivier.eu \
--cc=chengang@emindsoft.com.cn \
--cc=cmetcalf@ezchip.com \
--cc=edgar.iglesias@gmail.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).