From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkAdq-0003rs-3P for qemu-devel@nongnu.org; Wed, 14 Sep 2016 09:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkAdl-0001hW-Uh for qemu-devel@nongnu.org; Wed, 14 Sep 2016 09:54:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkAdl-0001ge-MS for qemu-devel@nongnu.org; Wed, 14 Sep 2016 09:54:17 -0400 References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> <20160913173933.4844ba9d@bahia> <029cd2cc-56e4-9299-3f77-8a0de0a9d35f@ozlabs.ru> From: Eric Blake Message-ID: <05a37cbe-6ddf-482f-3cc1-ab98ef857a36@redhat.com> Date: Wed, 14 Sep 2016 08:54:16 -0500 MIME-Version: 1.0 In-Reply-To: <029cd2cc-56e4-9299-3f77-8a0de0a9d35f@ozlabs.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q2Mg7WF6PpS36a5rOgllDe7GqCxIcSPaQ" Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , Greg Kurz Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q2Mg7WF6PpS36a5rOgllDe7GqCxIcSPaQ From: Eric Blake To: Alexey Kardashevskiy , Greg Kurz Cc: qemu-devel@nongnu.org Message-ID: <05a37cbe-6ddf-482f-3cc1-ab98ef857a36@redhat.com> Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> <20160913173933.4844ba9d@bahia> <029cd2cc-56e4-9299-3f77-8a0de0a9d35f@ozlabs.ru> In-Reply-To: <029cd2cc-56e4-9299-3f77-8a0de0a9d35f@ozlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/13/2016 11:23 PM, Alexey Kardashevskiy wrote: >>> >>> Also, we don't have to abbreviate; 'bridge-name' may be easier to >>> understand than 'br', as well as a mention of the default value if th= e >>> parameter is not supplied. >=20 >=20 > The existing NetdevBridgeOptions does not do this in json as well and i= t > does in qemu-options.hx, so does my patch. Do I have to fix a bridge fi= rst > before reposting this patch?... If that interface is already baked in as 'br', then leave it alone. >=20 > When exactly is the content of qapi-schema.json's comments shown to a u= ser? Not yet, but Marc-Andre has patches pending that merge qemu-options.hx and qemu-schema.json so that we have a single file with documentation, rather than two semi-inconsistent copies. >=20 >=20 >>> >> >> FWIW @br is consistent with what we already have in NetdevBridgeOption= s >> since 1.2. >=20 > Right, this is why "br=3D". Okay, the argument of consistency with pre-existing interfaces is reasonable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --q2Mg7WF6PpS36a5rOgllDe7GqCxIcSPaQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2VaIAAoJEKeha0olJ0NqueoH/jVAGmk3xjc1rcr5AvgK/y/H dcsgtv1C0ezwgH+2Hwe0J/DqkLdC+ptETBPCpDcTWr5y7F1wwvH6eqkiLdvthnVk hrXzXc7Lt37uE3HS2YPl1A5d/UITnOyzAbL2KprSPA74nGecHgvE3G2palN55C/l /qWzpWhWWXHlSbWdmBJooj42XEVVmeHTJkO8emGdYAW4EEJ3Ic0Oj4MYgVkEXu25 GoiiDoNh7xlpoSO+n+86Cf8LWL0EX13Nho/lksg3HhFtitfSRA/00xKKJoYETNWD TCTfZxRYUkNBWk9l6Apv0YYwpNXegSdqPIVLjzVJoOa4d/uuue++HK0Grnp5YBM= =ubjW -----END PGP SIGNATURE----- --q2Mg7WF6PpS36a5rOgllDe7GqCxIcSPaQ--