From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, cfontana@suse.de, ehabkost@redhat.com
Subject: Re: [PATCH 2/2] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor
Date: Fri, 26 Feb 2021 17:47:22 +0100 [thread overview]
Message-ID: <05a6b4db-039d-d23a-e721-b1bb45e274c9@amsat.org> (raw)
In-Reply-To: <20210226162022.375654-3-richard.henderson@linaro.org>
On 2/26/21 5:20 PM, Richard Henderson wrote:
> The helper_* functions must use GETPC() to unwind from TCG.
> The cpu_x86_* functions cannot, and directly calling the
> helper_* functions is a bug. Split out new functions that
> perform the work and can be used by both.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/tcg/fpu_helper.c | 50 ++++++++++++++++++++++++------------
> 1 file changed, 34 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-02-26 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:20 [PATCH 0/2] target/i386: Fix cpu_x86_{fsave,frstor,fxsave,fxrstor} Richard Henderson
2021-02-26 16:20 ` [PATCH 1/2] target/i386: Rename helper_fldt, helper_fstt Richard Henderson
2021-02-26 16:45 ` Philippe Mathieu-Daudé
2021-02-26 16:20 ` [PATCH 2/2] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Richard Henderson
2021-02-26 16:47 ` Philippe Mathieu-Daudé [this message]
2021-02-26 16:59 ` [PATCH 0/2] target/i386: Fix cpu_x86_{fsave,frstor,fxsave,fxrstor} Claudio Fontana
2021-02-26 17:12 ` Paolo Bonzini
2021-02-26 17:13 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a6b4db-039d-d23a-e721-b1bb45e274c9@amsat.org \
--to=f4bug@amsat.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).