From: Sebastian Ott <sebott@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, peterx@redhat.com,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load
Date: Wed, 17 Jan 2024 18:00:39 +0100 (CET) [thread overview]
Message-ID: <05a74a9f-255e-b7cf-d80f-a08247b3faeb@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKx9orvOMXV-e4S2gZCsFvoOOdv4s2Vu5V7ONnBeJkD0w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Wed, 17 Jan 2024, Marc-André Lureau wrote:
> On Tue, Jan 16, 2024 at 3:17 PM Sebastian Ott <sebott@redhat.com> wrote:
>> On Mon, 15 Jan 2024, marcandre.lureau@redhat.com wrote:
>>> + scanout->ds = qemu_create_displaysurface_pixman(res->image);
>>> + if (!scanout->ds) {
>>> + return -EINVAL;
>>> + }
>>
>> "qemu_create_displaysurface_pixman() never returns NULL." ;-)
>
> Right, I'll update the first patch.
>
> Other comments about this patch?
Nope, looks good to me.
Reviewed-by: Sebastian Ott <sebott@redhat.com>
prev parent reply other threads:[~2024-01-17 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 15:48 [PATCH 0/2] virtio-gpu: fix blob scanout post-load marcandre.lureau
2024-01-15 15:48 ` [PATCH 1/2] virtio-gpu: remove needless condition marcandre.lureau
2024-01-15 15:48 ` [PATCH 2/2] virtio-gpu: fix scanout migration post-load marcandre.lureau
2024-01-16 11:16 ` Sebastian Ott
2024-01-17 11:13 ` Marc-André Lureau
2024-01-17 17:00 ` Sebastian Ott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a74a9f-255e-b7cf-d80f-a08247b3faeb@redhat.com \
--to=sebott@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).