From: Paolo Bonzini <pbonzini@redhat.com>
To: "Jose R. Ziviani" <jziviani@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] meson: introduce modules_arch
Date: Mon, 20 Sep 2021 21:03:28 +0200 [thread overview]
Message-ID: <05b09438-43ef-bd40-2b0a-2fdebf0425bd@redhat.com> (raw)
In-Reply-To: <YUiGcjBviIqPIyJB@pizza>
On 20/09/21 15:02, Jose R. Ziviani wrote:
> But, in anyway, I'll still need to store the target architecture that
> can use such core module, like I did here in this patch. Otherwise,
> if I compile different targets at the same time, I'll end up with the
> same problem of targets trying to load wrong modules.
>
> I thought of using qom, but I think it will pollute module.c.
Alternatively, you could C-ify the contents of config-devices.mak, and
embed them in the per-arch modinfo-*.c; and record CONFIG_* symbols for
each module (e.g. '{ "CONFIG_QXL", "hw-display-qxl" }' from a
'module_config("CONFIG_QXL")' line in the global modinfo.c file. Then
before loading a module you do a binary search on the per-arch
config-devices array.
I hope the above is readable. :)
Paolo
next prev parent reply other threads:[~2021-09-20 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 1:29 [PATCH 0/2] modules: Improve modinfo.c architecture support Jose R. Ziviani
2021-09-17 1:29 ` [PATCH 1/2] meson: introduce modules_arch Jose R. Ziviani
2021-09-17 7:14 ` Gerd Hoffmann
2021-09-17 13:06 ` Jose R. Ziviani
2021-09-20 5:15 ` Gerd Hoffmann
2021-09-20 13:02 ` Jose R. Ziviani
2021-09-20 19:03 ` Paolo Bonzini [this message]
2021-09-21 13:46 ` Jose R. Ziviani
2021-09-23 7:18 ` Paolo Bonzini
2021-09-21 5:25 ` Gerd Hoffmann
2021-09-21 13:35 ` Jose R. Ziviani
2021-09-21 15:34 ` Gerd Hoffmann
2021-09-17 1:29 ` [PATCH 2/2] modules: use a list of supported arch for each module Jose R. Ziviani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05b09438-43ef-bd40-2b0a-2fdebf0425bd@redhat.com \
--to=pbonzini@redhat.com \
--cc=jziviani@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).