From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Richard W.M. Jones" <rjones@redhat.com>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, pbonzini@redhat.com
Subject: Re: [PATCH v2] tcg: Include "qemu/timer.h" for profile_getclock
Date: Fri, 3 Mar 2023 10:30:15 +0100 [thread overview]
Message-ID: <05b41d7f-11a6-18d6-5239-a30479c1cb89@linaro.org> (raw)
In-Reply-To: <20230303084948.3351546-1-rjones@redhat.com>
On 3/3/23 09:49, Richard W.M. Jones wrote:
> When CONFIG_PROFILER is set there are various undefined references to
> profile_getclock. Include the header which defines this function.
>
> For example:
>
> ../tcg/tcg.c: In function ‘tcg_gen_code’:
> ../tcg/tcg.c:4905:51: warning: implicit declaration of function ‘profile_getclock’ [-Wimplicit-function-declaration]
> 4905 | qatomic_set(&prof->opt_time, prof->opt_time - profile_getclock());
> | ^~~~~~~~~~~~~~~~
>
> Thanks: Philippe Mathieu-Daudé
;)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> accel/tcg/tcg-accel-ops.c | 1 +
> accel/tcg/translate-all.c | 1 +
> softmmu/runstate.c | 1 +
> tcg/tcg.c | 1 +
> 4 files changed, 4 insertions(+)
next prev parent reply other threads:[~2023-03-03 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 8:49 [PATCH v2] tcg: Include "qemu/timer.h" for profile_getclock Richard W.M. Jones
2023-03-03 9:30 ` Philippe Mathieu-Daudé [this message]
2023-03-04 18:24 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05b41d7f-11a6-18d6-5239-a30479c1cb89@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).