From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Amarnath Valluri <amarnath.valluri@intel.com>, qemu-devel@nongnu.org
Cc: patrick.ohly@intel.com, marcandre.lureau@gmail.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/8] Provide support for the software TPM emulator
Date: Thu, 4 May 2017 08:28:26 -0400 [thread overview]
Message-ID: <05c17619-e5df-7615-73e9-64b4b57fd570@linux.vnet.ibm.com> (raw)
In-Reply-To: <1493725969-19518-1-git-send-email-amarnath.valluri@intel.com>
On 05/02/2017 07:52 AM, Amarnath Valluri wrote:
> Briefly, Theses set of patches introduces:
> - new TPM backend driver to support software TPM emulators(swtpm(1)).
> - and few supported fixes/enhancements/cleanup to existing tpm backend code.
>
> The similar idea was initiated earliar(2) by Stefan Berger(CCed) with slightly
> different approach, using CUSE. As swtpm has excellent support for unix domain
> sockets, hence this implementation uses unix domain sockets to communicate
> with
> swtpm.
I think you would need something like this as well:
https://github.com/stefanberger/qemu-tpm/commit/9d8c9c3f0df288242d03f78d3b103099c1910574
https://github.com/stefanberger/qemu-tpm/commit/b9ea09d2e26eac92b4a1604a7afa695c4fc2735e
>
> When Qemu is configured with 'emulator' tpm backend, it spawns 'swtpm' and
> communicates its via Unix domain sockets.
>
> 1) https://github.com/stefanberger/swtpm
> 2) https://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00089.html
>
> ** Changes in V2:
> - Made spawnning swtpm optional
> - used QIOChannel instead of plain unix sockets
> - incorporated other fixes pointed in v1 review
>
> ** Changes in v3:
> - Addressed review comments made by Stefan Berger and Deniel P Berrange
>
> Amarnath Valluri (8):
> tpm-backend: Remove unneeded member variable from backend class
> tpm-backend: Move thread handling inside TPMBackend
> tpm-backend: Initialize and free data members in it's own methods
> tpm-backend: Made few interface methods optional
> tmp backend: Add new api to read backend TpmInfo
> tpm-backend: Move realloc_buffer() implementation to base class
> tpm-passthrough: move reusable code to utils
> tpm: Added support for TPM emulator
>
> backends/tpm.c | 121 +++--
> configure | 15 +-
> hmp.c | 31 +-
> hw/tpm/Makefile.objs | 1 +
> hw/tpm/tpm_emulator.c | 943 +++++++++++++++++++++++++++++++++++++++
> hw/tpm/tpm_ioctl.h | 243 ++++++++++
> hw/tpm/tpm_passthrough.c | 221 +++------
> hw/tpm/tpm_util.c | 25 ++
> hw/tpm/tpm_util.h | 4 +
> include/sysemu/tpm_backend.h | 65 ++-
> include/sysemu/tpm_backend_int.h | 41 --
> qapi-schema.json | 67 ++-
> qemu-options.hx | 53 ++-
> tpm.c | 36 +-
> 14 files changed, 1545 insertions(+), 321 deletions(-)
> create mode 100644 hw/tpm/tpm_emulator.c
> create mode 100644 hw/tpm/tpm_ioctl.h
> delete mode 100644 include/sysemu/tpm_backend_int.h
>
next prev parent reply other threads:[~2017-05-04 12:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 11:52 [Qemu-devel] [PATCH v3 0/8] Provide support for the software TPM emulator Amarnath Valluri
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 1/8] tpm-backend: Remove unneeded member variable from backend class Amarnath Valluri
2017-05-02 11:59 ` Marc-André Lureau
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 2/8] tpm-backend: Move thread handling inside TPMBackend Amarnath Valluri
2017-05-02 12:10 ` Marc-André Lureau
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 3/8] tpm-backend: Initialize and free data members in it's own methods Amarnath Valluri
2017-05-02 12:17 ` Marc-André Lureau
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 4/8] tpm-backend: Made few interface methods optional Amarnath Valluri
2017-05-02 12:29 ` Marc-André Lureau
2017-05-04 8:39 ` Amarnath Valluri
2017-05-04 11:06 ` [Qemu-devel] [PATCH v4 " Amarnath Valluri
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 5/8] tmp backend: Add new api to read backend TpmInfo Amarnath Valluri
2017-05-02 13:35 ` Eric Blake
2017-05-04 9:05 ` Amarnath Valluri
2017-05-04 11:17 ` [Qemu-devel] [PATCH v4 " Amarnath Valluri
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 6/8] tpm-backend: Move realloc_buffer() implementation to base class Amarnath Valluri
2017-05-02 15:54 ` Marc-André Lureau
2017-05-04 9:25 ` Amarnath Valluri
2017-05-04 9:32 ` Marc-André Lureau
2017-05-04 11:31 ` [Qemu-devel] [PATCH v4 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model Amarnath Valluri
2017-05-06 12:27 ` Marc-André Lureau
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 7/8] tpm-passthrough: move reusable code to utils Amarnath Valluri
2017-05-02 15:54 ` Marc-André Lureau
2017-05-02 11:52 ` [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator Amarnath Valluri
2017-05-02 16:05 ` Marc-André Lureau
2017-05-02 16:32 ` Stefan Berger
2017-05-02 16:58 ` Stefan Berger
2017-05-02 17:09 ` Marc-André Lureau
2017-05-02 17:19 ` Stefan Berger
2017-05-02 18:25 ` Patrick Ohly
2017-05-02 18:50 ` Marc-André Lureau
2017-05-02 19:35 ` Stefan Berger
2017-05-03 8:41 ` Daniel P. Berrange
2017-05-03 11:17 ` Dr. David Alan Gilbert
2017-05-03 11:24 ` Marc-André Lureau
2017-05-03 11:29 ` Daniel P. Berrange
2017-05-03 11:37 ` Marc-André Lureau
2017-05-03 14:42 ` Stefan Berger
2017-05-04 9:44 ` Patrick Ohly
2017-05-04 11:08 ` Stefan Berger
2017-05-02 12:25 ` [Qemu-devel] [PATCH v3 0/8] Provide support for the software " no-reply
2017-05-04 11:35 ` [Qemu-devel] [PATCH v4 8/8] tpm: Added support for " Amarnath Valluri
2017-05-04 12:28 ` Stefan Berger [this message]
2017-05-05 6:52 ` [Qemu-devel] [PATCH v3 0/8] Provide support for the software " Amarnath Valluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c17619-e5df-7615-73e9-64b4b57fd570@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=amarnath.valluri@intel.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=patrick.ohly@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).