qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [qemu-web PATCH] Gemfile: use a fixed version of sassc
Date: Thu, 19 Sep 2019 17:38:01 +0200	[thread overview]
Message-ID: <05e8d9b4-d877-8cc1-0ae8-439b9b70bd07@redhat.com> (raw)
In-Reply-To: <20190919130128.28770-1-pbonzini@redhat.com>

On 19/09/2019 15.01, Paolo Bonzini wrote:
> Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
> Gemfile was requiring an earlier version (2.1.0 in practice).
> Since the bug has been fixed, remove the workaround and instead
> require a fixed version.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Gemfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Gemfile b/Gemfile
> index b76a4fd..2117bba 100644
> --- a/Gemfile
> +++ b/Gemfile
> @@ -24,4 +24,4 @@ group :jekyll_plugins do
>  end
>  
>  # for https://github.com/sass/sassc-ruby/issues/146
> -gem "sassc", "< 2.2.0"
> +gem "sassc", ">= 2.2.1"

I think you could simply drop the two lines now, "bundle install" will
pick up the newer version anyway.

Both ways work for me, so for any of the two solutions:

Tested-by: Thomas Huth <thuth@redhat.com>


      reply	other threads:[~2019-09-19 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 13:01 [Qemu-devel] [qemu-web PATCH] Gemfile: use a fixed version of sassc Paolo Bonzini
2019-09-19 15:38 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05e8d9b4-d877-8cc1-0ae8-439b9b70bd07@redhat.com \
    --to=thuth@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).