From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxPN-0001DI-HY for qemu-devel@nongnu.org; Fri, 17 Jun 2016 13:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxPI-0003sc-EZ for qemu-devel@nongnu.org; Fri, 17 Jun 2016 13:18:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxPI-0003sP-9A for qemu-devel@nongnu.org; Fri, 17 Jun 2016 13:18:12 -0400 References: <1466181227-14934-1-git-send-email-alex.bennee@linaro.org> <1466181227-14934-7-git-send-email-alex.bennee@linaro.org> From: Paolo Bonzini Message-ID: <05fe3cfa-af21-fb9f-8faf-f4e6f07daaf6@redhat.com> Date: Fri, 17 Jun 2016 19:18:05 +0200 MIME-Version: 1.0 In-Reply-To: <1466181227-14934-7-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 6/7] linux-user: don't clone watchpoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, serge.fdrv@gmail.com, cota@braap.org, bobby.prani@gmail.com Cc: mark.burton@greensocs.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Riku Voipio On 17/06/2016 18:33, Alex Benn=C3=A9e wrote: > The watchpoint code is stubbed out for CONFIG_USER_ONLY so there is no > point attempting to copy the data here. Lets remove the code before the > RCU protection goes in. >=20 > Signed-off-by: Alex Benn=C3=A9e > --- > linux-user/main.c | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/linux-user/main.c b/linux-user/main.c > index 2901626..9a5d017 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -3812,14 +3812,6 @@ CPUArchState *cpu_copy(CPUArchState *env) > Note: Once we support ptrace with hw-debug register access, mak= e sure > BP_CPU break/watchpoints are handled correctly on clone. */ > cpu_breakpoints_clone(cpu, new_cpu); > - if (unlikely(cpu->watchpoints) && unlikely(cpu->watchpoints->len))= { > - CPUWatchpoint *wp; > - int i; > - for (i =3D 0; i < cpu->watchpoints->len; i++) { > - wp =3D &g_array_index(cpu->watchpoints, CPUWatchpoint, i); > - cpu_watchpoint_insert(new_cpu, wp->vaddr, wp->len, wp->fla= gs); > - } > - } > =20 > return new_env; > } >=20 Hmm, I am not sure. It's still the correct thing to do. Paolo