From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C8EC04AAD for ; Mon, 6 May 2019 15:10:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 971342053B for ; Mon, 6 May 2019 15:10:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 971342053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNfG3-0002lB-Qz for qemu-devel@archiver.kernel.org; Mon, 06 May 2019 11:10:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNfFG-0002Tj-Gb for qemu-devel@nongnu.org; Mon, 06 May 2019 11:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNfFF-0004DK-Fh for qemu-devel@nongnu.org; Mon, 06 May 2019 11:09:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50466) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNfFF-0004CW-6w for qemu-devel@nongnu.org; Mon, 06 May 2019 11:09:33 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14899308622B; Mon, 6 May 2019 15:09:31 +0000 (UTC) Received: from [10.3.116.15] (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 939D260C4D; Mon, 6 May 2019 15:09:30 +0000 (UTC) To: Yuval Shaia , marcel.apfelbaum@gmail.com, qemu-devel@nongnu.org References: <20190505105518.22793-1-yuval.shaia@oracle.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <05ff71d8-eb9d-08be-6081-dc66631b2034@redhat.com> Date: Mon, 6 May 2019 10:09:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190505105518.22793-1-yuval.shaia@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nztngm0K3efx2zZ60DPobRYyex9smZs52" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 06 May 2019 15:09:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH] hw/rdma: Add support for GID state changes for non-qmp frameworks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nztngm0K3efx2zZ60DPobRYyex9smZs52 From: Eric Blake To: Yuval Shaia , marcel.apfelbaum@gmail.com, qemu-devel@nongnu.org Message-ID: <05ff71d8-eb9d-08be-6081-dc66631b2034@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hw/rdma: Add support for GID state changes for non-qmp frameworks References: <20190505105518.22793-1-yuval.shaia@oracle.com> In-Reply-To: <20190505105518.22793-1-yuval.shaia@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/5/19 5:55 AM, Yuval Shaia wrote: > Any GID change in guest must be propogate to host. This is already done= s/propogate to/propagated to the/ > by firing QMP event to managment system such as libvirt which in turn s/managment/management/ > will update the host with the relevant change. >=20 > When qemu is executed on non-qmp framework (ex from command-line) we > need to update the host instead. > Fix it by adding support to update the RoCE device's Ethernet function > IP list from qemu via netlink. >=20 > Signed-off-by: Yuval Shaia > --- > configure | 6 ++++ > hw/rdma/rdma_backend.c | 74 +++++++++++++++++++++++++++++++++++++++++-= > 2 files changed, 79 insertions(+), 1 deletion(-) >=20 > @@ -1123,7 +1183,13 @@ int rdma_backend_add_gid(RdmaBackendDev *backend= _dev, const char *ifname, > gid->global.subnet_prefix,= > gid->global.interface_id);= > =20 > - return ret; > + /* > + * We ignore return value since operation might completed sucessfu= lly s/completed sucessfully/have completed successfully/ > + * by the QMP consumer > + */ > + netlink_route_update(ifname, gid, RTM_NEWADDR); > + > + return 0; > } > =20 > int rdma_backend_del_gid(RdmaBackendDev *backend_dev, const char *ifna= me, > @@ -1149,6 +1215,12 @@ int rdma_backend_del_gid(RdmaBackendDev *backend= _dev, const char *ifname, > gid->global.subnet_prefix,= > gid->global.interface_id);= > =20 > + /* > + * We ignore return value since operation might completed sucessfu= lly and again > + * by the QMP consumer > + */ > + netlink_route_update(ifname, gid, RTM_DELADDR); > + > return 0; > } > =20 >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --Nztngm0K3efx2zZ60DPobRYyex9smZs52 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlzQTikACgkQp6FrSiUn Q2rmhgf/TDq96xWcv9m6gkJ/HdTttTfZ0SH40kbBqb4mzulKW++0e3oIAVjsH1lz YOegHbOL8GNZT9i4moE3qj4OqGdu02dT/DzBQ9e9fHXdHWxn/FvayEuobLfLA6kx XI1AOOaeRfXwNOema9twA+CWpVGOpbRJlmeqnZhIO0DQDBdKsvXT2Fa09PCNwgsQ jMaiVhTWFEViFgzdnxlYq8cS1V3hGIMe1zmtgMD8MFI1ProaH9vBJLMMy7aWPBvV 7btPY1qRj+AFLQPiHdX2U7bBoXjvhPO1fzUGdwXM+NiOQcrCVPGDnmjANGEAsc94 pnroTVXUsIl0BMVyRsgJ77dO2FG7Lg== =jc5r -----END PGP SIGNATURE----- --Nztngm0K3efx2zZ60DPobRYyex9smZs52--