From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API
Date: Fri, 5 May 2023 10:22:20 +0200 [thread overview]
Message-ID: <060aee99-9b7b-ea86-cf74-8755ca416a0b@redhat.com> (raw)
In-Reply-To: <20230504081351.125140-1-thuth@redhat.com>
On 5/4/23 10:13, Thomas Huth wrote:
> Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned
> compatibility with Windows older than 8 - we should reflect this
> in our _WIN32_WINNT and set it to the value that corresponds to
> Windows 8.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> include/qemu/osdep.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 9eff0be95b..cc61b00ba9 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int);
> #ifdef _WIN32
> /* as defined in sdkddkver.h */
> #ifndef _WIN32_WINNT
> -#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */
> +#define _WIN32_WINNT 0x0602 /* Windows 8 API (should be >= the one from glib) */
> #endif
> /* reduces the number of implicitly included headers */
> #ifndef WIN32_LEAN_AND_MEAN
Queued, thanks.
Paolo
prev parent reply other threads:[~2023-05-05 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 8:13 [PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API Thomas Huth
2023-05-04 8:21 ` Daniel P. Berrangé
2023-05-04 15:13 ` Akihiko Odaki
2023-05-05 8:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060aee99-9b7b-ea86-cf74-8755ca416a0b@redhat.com \
--to=pbonzini@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).