From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 1/3] i386: Make Hyper-V related sections KVM only
Date: Thu, 18 Mar 2021 17:06:54 +0100 [thread overview]
Message-ID: <060ef1a9-0447-ddac-4694-7aba4676a36b@redhat.com> (raw)
In-Reply-To: <20210318160249.1084178-2-vkuznets@redhat.com>
On 18/03/21 17:02, Vitaly Kuznetsov wrote:
> Currently, Hyper-V enlightenments are only implemented by KVM so there's no
> need to have corresponding vmstate_x86_cpu sections when !CONFIG_KVM.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
I expect WHPX may implement at least some, so I'll leave this out.
Paolo
> ---
> target/i386/machine.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/i386/machine.c b/target/i386/machine.c
> index 3967dfc25763..a4777a73b0a9 100644
> --- a/target/i386/machine.c
> +++ b/target/i386/machine.c
> @@ -697,6 +697,7 @@ static const VMStateDescription vmstate_mpx = {
> }
> };
>
> +#ifdef CONFIG_KVM
> static bool hyperv_hypercall_enable_needed(void *opaque)
> {
> X86CPU *cpu = opaque;
> @@ -895,6 +896,7 @@ static const VMStateDescription vmstate_msr_hyperv_reenlightenment = {
> VMSTATE_END_OF_LIST()
> }
> };
> +#endif
>
> static bool avx512_needed(void *opaque)
> {
> @@ -1484,6 +1486,7 @@ VMStateDescription vmstate_x86_cpu = {
> &vmstate_msr_ia32_feature_control,
> &vmstate_msr_architectural_pmu,
> &vmstate_mpx,
> +#ifdef CONFIG_KVM
> &vmstate_msr_hypercall_hypercall,
> &vmstate_msr_hyperv_vapic,
> &vmstate_msr_hyperv_time,
> @@ -1492,6 +1495,7 @@ VMStateDescription vmstate_x86_cpu = {
> &vmstate_msr_hyperv_synic,
> &vmstate_msr_hyperv_stimer,
> &vmstate_msr_hyperv_reenlightenment,
> +#endif
> &vmstate_avx512,
> &vmstate_xss,
> &vmstate_umwait,
>
next prev parent reply other threads:[~2021-03-18 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 16:02 [PATCH 0/3] i386: Make sure TSC frequency is preserved across migration when Hyper-V reenlightenment is in use Vitaly Kuznetsov
2021-03-18 16:02 ` [PATCH 1/3] i386: Make Hyper-V related sections KVM only Vitaly Kuznetsov
2021-03-18 16:06 ` Paolo Bonzini [this message]
2021-03-18 16:02 ` [PATCH 2/3] i386: Fix 'hypercall_hypercall' typo Vitaly Kuznetsov
2021-03-18 16:12 ` Paolo Bonzini
2021-03-18 16:02 ` [PATCH 3/3] i386: Make sure kvm_arch_set_tsc_khz() succeeds on migration when 'hv-reenlightenment' was exposed Vitaly Kuznetsov
2021-03-18 16:12 ` Paolo Bonzini
2021-03-18 16:38 ` Vitaly Kuznetsov
2021-03-18 17:36 ` Paolo Bonzini
2021-03-19 9:41 ` Vitaly Kuznetsov
2021-03-19 11:04 ` Paolo Bonzini
2021-03-19 12:02 ` Vitaly Kuznetsov
2021-03-18 18:03 ` Marcelo Tosatti
2021-03-19 9:46 ` Vitaly Kuznetsov
2021-03-18 20:13 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060ef1a9-0447-ddac-4694-7aba4676a36b@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).